Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin hermes-engine to 0.8.x for RN 0.65 #31456

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

Huxpro
Copy link
Contributor

@Huxpro Huxpro commented Apr 29, 2021

Summary

Changelog

[Breaking][Changed] - Pin Hermes to 0.8.0 in the react_native_pods.rb script

Test Plan

CircleCI

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Apr 29, 2021
@pull-bot
Copy link

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than master. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on master first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.

Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 275bde5

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,863,231 -112,292
android hermes armeabi-v7a 8,385,686 -102,282
android hermes x86 9,320,911 -106,953
android hermes x86_64 9,264,648 -105,224
android jsc arm64-v8a 10,592,348 -111
android jsc armeabi-v7a 10,097,902 -43
android jsc x86 10,611,517 -16
android jsc x86_64 11,195,526 +79

Base commit: b44f4dd

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: b44f4dd

@Huxpro Huxpro marked this pull request as ready for review April 30, 2021 00:47
@Huxpro Huxpro merged commit 63ddb1d into facebook:0.65-stable Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants