Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AppContainer] Add back legacy rootTag childContex #31492

Merged
merged 1 commit into from
May 7, 2021

Conversation

nadiia
Copy link

@nadiia nadiia commented May 7, 2021

Summary

Reverting the legacy rootTag childContext in AppContainer for 0.65 release. It will be deprecated and removed in the following release.

Changelog

[General] [Changed] - [AppContainer] Add back legacy rootTag childContex

Test Plan

CI test run

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels May 7, 2021
@pull-bot
Copy link

pull-bot commented May 7, 2021

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than master. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on master first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.

Generated by 🚫 dangerJS against 325aa5f

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 1e39d8b

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,863,295 -123,367
android hermes armeabi-v7a 8,385,755 -108,154
android hermes x86 9,320,969 -117,974
android hermes x86_64 9,264,719 -115,992
android jsc arm64-v8a 10,592,385 -12,758
android jsc armeabi-v7a 10,097,940 -7,480
android jsc x86 10,611,563 -12,587
android jsc x86_64 11,195,564 -12,261

Base commit: 1e39d8b

@TheSavior TheSavior merged commit 6d31b71 into facebook:0.65-stable May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants