Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing @jest/create-cache-key-function dep root package.json #31668

Closed
wants to merge 1 commit into from

Conversation

janicduplessis
Copy link
Contributor

Summary

@jest/create-cache-key-function should be installed as part of the react-native package since it is used by the jest config. Running jest currently errors unless this package is somehow transitively installed.

Changelog

[General] [Fixed] - Add missing @jest/create-cache-key-function dep root package.json

Test Plan

Run jest in a RN app.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. labels Jun 6, 2021
@pull-bot
Copy link

pull-bot commented Jun 6, 2021

Warnings
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against ed5fe91

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 3827ca6

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 9,239,326 -582
android hermes armeabi-v7a 8,749,254 -597
android hermes x86 9,701,633 -587
android hermes x86_64 9,666,846 -588
android jsc arm64-v8a 10,886,324 -575
android jsc armeabi-v7a 9,787,542 -573
android jsc x86 10,944,044 -573
android jsc x86_64 11,550,791 -565

Base commit: 3827ca6

@lunaleaps lunaleaps self-assigned this Jun 8, 2021
@facebook-github-bot
Copy link
Contributor

@lunaleaps has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@lunaleaps
Copy link
Contributor

Imported this in and asked @rubennorte about this change. I think the understanding is that package.json dependencies should be product dependencies and the repo-config/package.json is about build/test tools.

Should users of react-native not yarn install on the repo-config/package.json? Is it just lack of education or something else?
cc
@rubennorte if I misunderstood

@janicduplessis
Copy link
Contributor Author

@lunaleaps My understanding is repo-config/package.json is for dependencies that are used only when working in the react-native repo directly (similar to devDependencies, not sure the exact reason why it is setup this way vs using devDeps). I don't think the repo-config package is published to npm or is meant to be.

The case here is that @jest/create-cache-key-function is used by the jest preset included in the react-native package (not just for the repo internal tests).

@rubennorte
Copy link
Contributor

The case here is that @jest/create-cache-key-function is used by the jest preset included in the react-native package (not just for the repo internal tests).

@janicduplessis yeah, I missed that in my original change. Thanks for fixing this!

@facebook-github-bot
Copy link
Contributor

@lunaleaps merged this pull request in 9a43eac.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants