Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Android deps to 0.91 #31675

Closed
wants to merge 2 commits into from
Closed

Bump Android deps to 0.91 #31675

wants to merge 2 commits into from

Conversation

mweststrate
Copy link
Contributor

Summary:
As requested in parent diff, moved the Android dep bumps into a separate diff.

Changelog

[general][changed] - [Android] Update Flipper to 0.91.1

Reviewed By: mdvacca, ShikaSD

Differential Revision: D28688486

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Jun 7, 2021
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D28688486

@mweststrate mweststrate marked this pull request as draft June 7, 2021 09:32
@mweststrate
Copy link
Contributor Author

This is just a PR to verify public CI for above mentioned diff. Will land from phabricator if all is green.

@pull-bot
Copy link

pull-bot commented Jun 7, 2021 •
edited

Messages
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against 124c1dd

@analysis-bot
Copy link

analysis-bot commented Jun 7, 2021 •
edited

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 2a6df5b

@analysis-bot
Copy link

analysis-bot commented Jun 7, 2021 •
edited

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 9,215,022 -7,331
android hermes armeabi-v7a 8,714,101 -30,340
android hermes x86 9,666,059 -19,737
android hermes x86_64 9,633,792 -13,788
android jsc arm64-v8a 10,858,880 -8,712
android jsc armeabi-v7a 9,749,238 -31,726
android jsc x86 10,905,332 -21,114
android jsc x86_64 11,514,582 -15,167

Base commit: e31e2cc

dulmandakh
dulmandakh reviewed Jun 7, 2021
View reviewed changes
build.gradle.kts Outdated
@@ -33,6 +33,28 @@ allprojects {
mavenLocal()
google()
mavenCentral()
jcenter {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we just leave fresco, because it would require some extra work on Buck.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you elaborate a little bit? This PR was green before public and internal, but I needed to rebase and in the mean time 70da640 happened. Is that something that should partially be reversed? Afaik everything seems to be green atm, except for test_docker job. Does that relate to the extra Buck work?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend to not touch other dependencies unless necessary. Here is Fresco in Buck, you need to update in here too https://github.com/facebook/react-native/blob/dc80b2dcb52fadec6a573a9dd1824393f8c29fdc/ReactAndroid/src/main/libraries/fresco/fresco-react-native/BUCK

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also it would be nice to remove below lines in https://github.com/facebook/react-native/blob/master/template/android/app/build.gradle and https://github.com/facebook/react-native/blob/master/packages/rn-tester/android/app/build.gradle because it's unnecessary with the Flipper bump.

debugImplementation("com.facebook.fresco:stetho:2.3.0")
exclude group:'com.facebook.fresco', module:'stetho'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_docker failure is not related to your change. I can open a PR very soon

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where did you get the hashes from in the previous update? Sorry I don't really grok the RN stack :). I merely wanted to bump the Flipper version but the rabbit hole goes a bit deeper than anticipated 😢

@dulmandakh
Copy link
Contributor

@mweibel this patch will fix test_docker job

diff --git a/ReactAndroid/src/main/third-party/kotlin/BUCK b/ReactAndroid/src/main/third-party/kotlin/BUCK
index caad9d63e62..49d72ef5c59 100644
--- a/ReactAndroid/src/main/third-party/kotlin/BUCK
+++ b/ReactAndroid/src/main/third-party/kotlin/BUCK
@@ -62,7 +62,7 @@ rn_prebuilt_jar(
 
 fb_native.remote_file(
     name = "kotlin-stdlib-common.jar",
-    sha1 = "6229be3465805c99db1142ad75e6c6ddeac0b04c",
+    sha1 = "4fbce226ea33edfb7a42c87ae09330b07bbf1fce",
     url = "mvn:org.jetbrains.kotlin:kotlin-stdlib-common:jar:1.4.10",
 )

@Titozzz
Copy link
Collaborator

Titozzz commented Jun 7, 2021

@mweibel this patch will fix test_docker job

diff --git a/ReactAndroid/src/main/third-party/kotlin/BUCK b/ReactAndroid/src/main/third-party/kotlin/BUCK
index caad9d63e62..49d72ef5c59 100644
--- a/ReactAndroid/src/main/third-party/kotlin/BUCK
+++ b/ReactAndroid/src/main/third-party/kotlin/BUCK
@@ -62,7 +62,7 @@ rn_prebuilt_jar(
 
 fb_native.remote_file(
     name = "kotlin-stdlib-common.jar",
-    sha1 = "6229be3465805c99db1142ad75e6c6ddeac0b04c",
+    sha1 = "4fbce226ea33edfb7a42c87ae09330b07bbf1fce",
     url = "mvn:org.jetbrains.kotlin:kotlin-stdlib-common:jar:1.4.10",
 )

I think you meant @mweststrate

@Titozzz Titozzz mentioned this pull request Jun 7, 2021
Closed
38 tasks
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D28688486

mweststrate added a commit to mweststrate/react-native that referenced this pull request Jun 7, 2021
@mweststrate @facebook-github-bot
Bump Android deps to 0.91 (facebook#31675)
7bbe6d0 
Summary:
Pull Request resolved: facebook#31675

As requested in parent diff, moved the Android dep bumps into a separate diff.

## Changelog

[general][changed] - [Android] Update Flipper to 0.91.1

Reviewed By: mdvacca, ShikaSD

Differential Revision: D28688486

fbshipit-source-id: 3196d332298bb1505a1d3579774eeef22f7840bd
@kelset kelset mentioned this pull request Jun 9, 2021
Closed
9 tasks
dulmandakh and others added 2 commits June 11, 2021 02:46
@dulmandakh @facebook-github-bot
bump fresco to 2.5.0 (facebook#31699)
61afbac 
Summary:
This PR bumps Fresco to 2.5.0, which is first version on MavenCentral since jCenter announcement.

## Changelog

[Android] [Changed] - Bump Fresco to 2.5.0

Pull Request resolved: facebook#31699

Test Plan: CI is green

Differential Revision: D29031847

Pulled By: passy

fbshipit-source-id: c75753c07aa44ec8168f8d3d0f05cb43cceccbc2
@mweststrate @facebook-github-bot
Bump Android deps to 0.93 (facebook#31675)
124c1dd 
Summary:
Pull Request resolved: facebook#31675

As requested in parent diff, moved the Android dep bumps into a separate diff.

## Changelog

[general][changed] - [Android] Update Flipper to 0.93.0

Reviewed By: mdvacca, ShikaSD

Differential Revision: D28688486

fbshipit-source-id: 4fa35771d96c1c658191754ef8f9341ed8262b05
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D28688486

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 06c33e9.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jun 11, 2021
kelset pushed a commit that referenced this pull request Jun 16, 2021
@mweststrate @kelset
Bump Android deps to 0.93 (#31675)
d8b115a 
Summary:
Pull Request resolved: #31675

As requested in parent diff, moved the Android dep bumps into a separate diff.

## Changelog

[general][changed] - [Android] Update Flipper to 0.93.0

Reviewed By: mdvacca, ShikaSD

Differential Revision: D28688486

fbshipit-source-id: c3a8e0edeebdabd490b2885497e261f64bdab4bd
@charlesbdudley charlesbdudley mentioned this pull request Jul 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dulmandakh dulmandakh dulmandakh left review comments

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mweststrate @facebook-github-bot @pull-bot @analysis-bot @dulmandakh @Titozzz