New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minPressDuration prop to Pressable component. #32699
Add minPressDuration prop to Pressable component. #32699
Conversation
…p to Pressability configuration.
Hi @hubConnect! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Base commit: b0bae21 |
Base commit: b0bae21 |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Any chance of getting this approved? It would be helpful for me to be able to utilize Pressable and not have to host a version just for this change. |
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This PR was closed because it has been stalled for 7 days with no activity. |
Add minPressDuration prop to Pressable component. Pass minDurationProp to Pressability configuration.
Summary
Adds the minPressDuration prop to the Pressable component. While working on a timing sensitive component for a project, we noticed that there was significant time between the onPressIn and onPressOut events when compared to the Touchable components. After looking through some previous issues related to timing, this seemed to be unintentional.
Changelog
[General] [Fixed] Added minPressDuration prop to the Pressable component, pass this prop to the Pressability config file.
Test Plan
Quick screen grab of the log to show the difference between not supplying the prop(default minPressDuration), and supplying a prop of
minPressDuration={0}
Closes #32716