Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minPressDuration prop to Pressable component. #32699

Conversation

hubConnect
Copy link

@hubConnect hubConnect commented Dec 2, 2021

Add minPressDuration prop to Pressable component. Pass minDurationProp to Pressability configuration.

Summary

Adds the minPressDuration prop to the Pressable component. While working on a timing sensitive component for a project, we noticed that there was significant time between the onPressIn and onPressOut events when compared to the Touchable components. After looking through some previous issues related to timing, this seemed to be unintentional.

Changelog

[General] [Fixed] Added minPressDuration prop to the Pressable component, pass this prop to the Pressability config file.

Test Plan

image

Quick screen grab of the log to show the difference between not supplying the prop(default minPressDuration), and supplying a prop of minPressDuration={0}

Closes #32716

@facebook-github-bot
Copy link
Contributor

Hi @hubConnect!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@analysis-bot
Copy link

analysis-bot commented Dec 2, 2021

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: b0bae21
Branch: main

@analysis-bot
Copy link

analysis-bot commented Dec 3, 2021

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,121,004 +43
android hermes armeabi-v7a 7,720,998 +45
android hermes x86 8,490,487 +45
android hermes x86_64 8,442,447 +40
android jsc arm64-v8a 9,787,666 +20
android jsc armeabi-v7a 8,772,544 +17
android jsc x86 9,753,736 +13
android jsc x86_64 10,349,791 +15

Base commit: b0bae21
Branch: main

@react-native-bot react-native-bot added the No CLA Authors need to sign the CLA before a PR can be reviewed. label Dec 3, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Dec 3, 2021
@react-native-bot react-native-bot removed the No CLA Authors need to sign the CLA before a PR can be reviewed. label Dec 3, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@hubConnect
Copy link
Author

Any chance of getting this approved? It would be helpful for me to be able to utilize Pressable and not have to host a version just for this change.

@github-actions
Copy link

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Nov 12, 2022
Copy link

github-actions bot commented Apr 6, 2024

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pressable does not pass minPressDuration prop to Pressability config
4 participants