fix: find-node.sh now respects .nvmrc

[igrayson]

Summary

React-native Xcode build steps (such as "Build JS Bundle") rely on find.node-sh to find the correct node binary, using nvm if present. We do this because Xcode may run build steps in a fresh shell environment, presumably for repeatable builds.

This PR fixes find-node.sh, to respect any .nvmrc file that may be present in the build environment.

Today: find-node.sh will set the shell environment to the system node version, and ignores any .nvmrc the project may provide to pin node for repeatable builds. By ignoring .nvmrc, node versions may differ depending on system environment — between developer laptops, or between developer and CI environments. 😞

This problem has been been noticed before in #8887

Should this fix happen upstream?

Unfortunately this nvm behavior is intended, for backwards compatibility

Changelog

[iOS] [Fixed] - find-node.sh now respects .nvmrc

Test Plan

Before:

# nvm isn't loaded
$ which nvm

# we're on default system node
$ which node && node --version
/usr/local/bin/node
v17.0.1

$ echo v16.13.0 > .nvmrc
$ source ./scripts/find-node.sh

# Expected: v16.13.0
$ node --version
v17.0.1

After:

# we're on default system node
$ which node && node --version
/usr/local/bin/node
v17.0.1

$ echo v16.13.0 > .nvmrc
$ source ./scripts/find-node.sh

# Expected: v16.13.0
$ node --version
v16.13.0

After (no .nvmrc, should preserve previous behavior):

# we're on default system node
$ which node && node --version
/usr/local/bin/node
v17.0.1

$ source ./scripts/find-node.sh

$  nvm ls|grep default
default -> v14.17.1

# Expected: v14.17.1
$ node --version
v14.17.1

[facebook-github-bot]

Hi @igrayson!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 6624327
Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,291,929	+0
android	hermes	armeabi-v7a	7,622,622	+0
android	hermes	x86	8,762,241	+0
android	hermes	x86_64	8,701,375	+0
android	jsc	arm64-v8a	9,680,208	+0
android	jsc	armeabi-v7a	8,667,587	+0
android	jsc	x86	9,636,020	+0
android	jsc	x86_64	10,232,757	+0

Base commit: 6624327
Branch: main

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[facebook-github-bot]

@ShikaSD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @igrayson in 35bcf93.

^{When will my fix make it into a release? | Upcoming Releases}