Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog for 0.68 #32993

Closed
wants to merge 12 commits into from
Closed

Changelog for 0.68 #32993

wants to merge 12 commits into from

Conversation

ShikaSD
Copy link
Contributor

@ShikaSD ShikaSD commented Jan 28, 2022

Summary

Adds changelog for 0.68

Changelog

[Internal][Changed] - Add changelog for 0.68

Test Plan

N/A

@ShikaSD ShikaSD added the 📝 Changelog This identifies PRs that touch the changelog label Jan 28, 2022
@ShikaSD ShikaSD requested a review from hramos as a code owner January 28, 2022 19:42
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jan 28, 2022
@analysis-bot
Copy link

analysis-bot commented Jan 28, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: e3c88eb
Branch: main

@analysis-bot
Copy link

analysis-bot commented Jan 28, 2022

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,960,606 -18,433
android hermes armeabi-v7a 7,552,304 +199,973
android hermes x86 8,298,446 -16,117
android hermes x86_64 8,266,774 -16,815
android jsc arm64-v8a 9,619,637 -7,411
android jsc armeabi-v7a 8,599,257 +197,478
android jsc x86 9,570,057 -6,190
android jsc x86_64 10,165,993 -7,222

Base commit: e3c88eb
Branch: main

Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions here and there after the initial pass of the changelog content.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@lunaleaps lunaleaps mentioned this pull request Feb 1, 2022
CHANGELOG.md Show resolved Hide resolved

#### Android specific

- Enable cliPath to have an absolute path value ([5d560ca99f](https://github.com/facebook/react-native/commit/5d560ca99ff7220de11d2d76dbe77d73990894a8) by [@Krisztiaan](https://github.com/Krisztiaan))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit grew a bit since this description, and also includes trying to resolve cliPath via node when no config is present.

ShikaSD and others added 2 commits March 23, 2022 14:05
Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
Co-authored-by: Lorenzo Sciandra <lorenzo.sciandra@gmail.com>
@facebook-github-bot
Copy link
Contributor

@ShikaSD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @ShikaSD in 57a90f7.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Mar 30, 2022
Saadnajmi pushed a commit to Saadnajmi/react-native-macos that referenced this pull request Jan 15, 2023
Summary:
Adds changelog for 0.68

## Changelog

[Internal][Changed] - Add changelog for 0.68

Pull Request resolved: facebook#32993

Test Plan: N/A

Reviewed By: cortinico

Differential Revision: D35250711

Pulled By: ShikaSD

fbshipit-source-id: a794a35c98a759808f4e70fbf71bd8b5787b5990
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📝 Changelog This identifies PRs that touch the changelog CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants