Do not bundle libhermes.so or libjsc.so inside the React Native Android AAR #33038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…id AAR Summary: While rolling out RN 0.68.x we noticed that `libhermes.so` and `libjsc.so` were included inside the final .aar we publish to NPM. This forced users (on both old or new arch) to specify a `pickFirst` directive inside their packaging option (which is unpractical and risky as the two .so might not be compatible each other if they're coming from different Hermes/JSC versions). Changelog: [Android] [Fixed] - Do not bundle libhermes.so or libjsc.so inside the React Native Android AAR Differential Revision: D33979107 fbshipit-source-id: 69b9271ac4c28a69a5abc49866685281bd41abd9
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D33979107 |
Base commit: 4cbcb7a |
Base commit: 4cbcb7a |
|
This pull request was successfully merged by @cortinico in fa85417. When will my fix make it into a release? | Upcoming Releases |
ShikaSD
pushed a commit
that referenced
this pull request
Feb 3, 2022
…id AAR (#33038) Summary: Pull Request resolved: #33038 While rolling out RN 0.68.x we noticed that `libhermes.so` and `libjsc.so` were included inside the final .aar we publish to NPM. This forced users (on both old or new arch) to specify a `pickFirst` directive inside their packaging option (which is unpractical and risky as the two .so might not be compatible each other if they're coming from different Hermes/JSC versions). Changelog: [Android] [Fixed] - Do not bundle libhermes.so or libjsc.so inside the React Native Android AAR Reviewed By: ShikaSD Differential Revision: D33979107 fbshipit-source-id: 0b71d59f210b8bc9903cd0f30ed6e2120aab99e0
This was referenced Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
While rolling out RN 0.68.x we noticed that
libhermes.soandlibjsc.sowere includedinside the final .aar we publish to NPM. This forced users (on both old or new arch) to
specify a
pickFirstdirective inside their packaging option (which is unpractical andrisky as the two .so might not be compatible each other if they're coming from
different Hermes/JSC versions).
Changelog:
[Android] [Fixed] - Do not bundle libhermes.so or libjsc.so inside the React Native Android AAR
Differential Revision: D33979107