Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle: Deprecate reactRoot in favor of root and reactNativeDir #33142

Closed
wants to merge 1 commit into from

Commits on Feb 18, 2022

  1. Gradle: Deprecate reactRoot in favor of root and reactNativeDir

    Summary:
    The `reactRoot` property was confusing as we were using it for both the root of the project
    and the react-native NPM Package root. I'm deprecating it and splitting it in two.
    
    I've added several warning in the codebase to tell the people how to migrate away from it.
    Moreover this is specifying default values that are more user-friendly. Users won't have to
    configure anything unless they are in a monorepo.
    
    Changelog:
    [Android] [Changed] - Gradle: Deprecate `reactRoot` in favor of `root` and `reactNativeDir`
    
    Reviewed By: ShikaSD
    
    Differential Revision: D34277050
    
    fbshipit-source-id: 23ee57ee744a1b2d45b78b9596cc8b0675e235dc
    cortinico authored and facebook-github-bot committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    dea8ecf View commit details
    Browse the repository at this point in the history