Fix OSS native Android build #33167
Closed
Fix OSS native Android build #33167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 23, 2022 07:33
Differential Revision: D34417682 fbshipit-source-id: 330166739f55f95c1c58f0a7782499c4912efb84
Summary: The build is failing with: ``` error: undefined reference to 'folly::SharedMutexImpl<false, void, std::__ndk1::atomic, folly::SharedMutexPolicyDefault>::unlock_shared()' ``` Indicating missing link to `folly_futures`. Changelog: [Internal] Differential Revision: D34419236 fbshipit-source-id: 86c78933093afa749dcb3be54bae72538eb273e6
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D34419236 |
Base commit: b1a7793 |
|
This pull request was successfully merged by @ShikaSD in 78f6cdf. When will my fix make it into a release? | Upcoming Releases |
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jan 15, 2023
Summary: Pull Request resolved: facebook#33167 The build is failing with: ``` error: undefined reference to 'folly::SharedMutexImpl<false, void, std::__ndk1::atomic, folly::SharedMutexPolicyDefault>::unlock_shared()' ``` Indicating missing link to `folly_futures`. Changelog: [Internal] Reviewed By: cortinico, GijsWeterings Differential Revision: D34419236 fbshipit-source-id: ca777e0c3a13c2f23791a94b13de18911c93edd5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The build is failing with:
Indicating missing link to
folly_futures.Changelog: [Internal]
Differential Revision: D34419236