Include folly fabric headers in source files #33188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Base commit: 189c2c8 |
Base commit: 189c2c8 |
|
@motiz88 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cortinico
approved these changes
Feb 28, 2022
|
This pull request was successfully merged by @danilobuerger in 56dda14. When will my fix make it into a release? | Upcoming Releases |
ShikaSD
pushed a commit
that referenced
this pull request
Mar 16, 2022
Summary: See the main spec preserve_paths, they are all also included as source_files. Without this, the folly fabric header files won't be available for other pods. ## Changelog [iOS] [Fixed] - Include folly fabric headers in source files Pull Request resolved: #33188 Test Plan: Include react-native-safe-area-context 4.0.1 with new architecture active. It will result in a xcode build error: <img width="466" alt="Screenshot 2022-02-26 at 19 33 35" src="https://user-images.githubusercontent.com/996231/155855017-8ea5f473-42a0-4e56-8108-472e6224ae7e.png"> Reviewed By: cortinico Differential Revision: D34518841 Pulled By: motiz88 fbshipit-source-id: 1053fe204331a314427c793f28b2458e7b78e6c5
This was referenced Apr 21, 2022
This was referenced Nov 14, 2022
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jan 15, 2023
Summary: See the main spec preserve_paths, they are all also included as source_files. Without this, the folly fabric header files won't be available for other pods. ## Changelog [iOS] [Fixed] - Include folly fabric headers in source files Pull Request resolved: facebook#33188 Test Plan: Include react-native-safe-area-context 4.0.1 with new architecture active. It will result in a xcode build error: <img width="466" alt="Screenshot 2022-02-26 at 19 33 35" src="https://user-images.githubusercontent.com/996231/155855017-8ea5f473-42a0-4e56-8108-472e6224ae7e.png"> Reviewed By: cortinico Differential Revision: D34518841 Pulled By: motiz88 fbshipit-source-id: 1053fe204331a314427c793f28b2458e7b78e6c5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See the main spec preserve_paths, they are all also included as source_files. Without this, the folly fabric header files won't be available for other pods.
Changelog
[iOS] [Fixed] - Include folly fabric headers in source files
Test Plan
Include react-native-safe-area-context 4.0.1 with new architecture active. It will result in a xcode build error: