Avoid full copy of large folly::dynamic objects by switching to std::move semantics

[NikoAri]

Summary

Problem:
Current creation of ModuleConfig does a full copy of folly::dynamic object, which for large objects can cause 1000's of memory allocations, and thus increasing app's memory footprint and speed.

Fix:
Use std::move semantics to avoid copy of folly::dynamic, thus avoiding memory allocations.

Changelog

[General] [Fixed] - Avoid full copy of large folly::dynamic objects by switching to std::move semantics

Test Plan

Compiled React Native for Windows
Consumed into Microsoft Excel App
Tested functionality through Microsoft Office Excel App
Viewed Memory Allocations in Debugger

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: 46ab59c
Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,773,873	-12
android	hermes	armeabi-v7a	7,179,764	-59
android	hermes	x86	8,083,112	+43
android	hermes	x86_64	8,061,683	+7
android	jsc	arm64-v8a	9,646,881	-11
android	jsc	armeabi-v7a	8,421,159	-54
android	jsc	x86	9,596,168	+49
android	jsc	x86_64	10,193,524	+9

Base commit: 46ab59c
Branch: main

[facebook-github-bot]

@RSNara has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @NikoAri in 3f98c8e.

^{When will my fix make it into a release? | Upcoming Releases}