[fix] backport FlipperConfiguration from main #34098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
facebook-github-bot
added
the
Shared with Meta
7 tasks
2 tasks
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 22, 2022
Summary: ### Mentioned - pr[main]: #33882 - discussion: reactwg/react-native-releases#21 (reply in thread) - pr[0.69-stable]: #34098 Close: #33764 Saw the issue ago couple wks too: leotm/react-native-template-new-architecture#757 Fixed similarly: leotm/react-native-template-new-architecture#791 ## Changelog [iOS] [Changed] - Update Podfile to allow `PRODUCTION=1 pod install` [CATEGORY] [TYPE] - Message Pull Request resolved: #34234 Test Plan: Everything builds and runs as expected Reviewed By: cortinico Differential Revision: D38029117 Pulled By: cipolleschi fbshipit-source-id: bdb58200a999cb66f1043a2feb670f9037c8e463
thymikee
pushed a commit
to thymikee/react-native
that referenced
this pull request
Jul 25, 2022
thymikee
pushed a commit
to thymikee/react-native
that referenced
this pull request
Jul 25, 2022
kelset
pushed a commit
that referenced
this pull request
Jul 27, 2022
Summary: ### Mentioned - pr[main]: #33882 - discussion: reactwg/react-native-releases#21 (reply in thread) - pr[0.69-stable]: #34098 Close: #33764 Saw the issue ago couple wks too: leotm/react-native-template-new-architecture#757 Fixed similarly: leotm/react-native-template-new-architecture#791 ## Changelog [iOS] [Changed] - Update Podfile to allow `PRODUCTION=1 pod install` [CATEGORY] [TYPE] - Message Pull Request resolved: #34234 Test Plan: Everything builds and runs as expected Reviewed By: cortinico Differential Revision: D38029117 Pulled By: cipolleschi fbshipit-source-id: bdb58200a999cb66f1043a2feb670f9037c8e463
|
How to specify Flipper version now? Instead of Update: |
|
@Bardiamist exactly right ^ we had to same question in then figured from here presumably react-native/scripts/cocoapods/flipper.rb Line 105 in 463af23 so it could be worth us expanding on the comment here or adding an example for others in the future react-native/template/ios/Podfile Line 20 in 463af23 |
This was referenced Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR backports FlipperConfiguration and the changes to the template Podfile so that apps created with React Native does not install Flipper pods when the dependencies are installed with
PRODUCTION=1 bundle exec pod install.When dependencies are installed using that command, Flipper won't be added as a dependency to the project and we can build the app using the Release schema.
Changelog
[iOS] [Fix] - Make sure that Flipper pods are not installed when creating a release build.
Test Plan
CircleCI passes