Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bake prod env var into react_native_pods.rb for iOS Release build #34234

Closed
wants to merge 4 commits into from
Closed

Bake prod env var into react_native_pods.rb for iOS Release build #34234

wants to merge 4 commits into from

Commits on Jul 20, 2022

  1. Allow PRODUCTION=1 pod install 

    Mentioned in
- reactwg/react-native-releases#21 (reply in thread)
  - #33882

Close: #33764
    @leotm
    leotm committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    7b088b1 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2022

  1. Revert "Allow PRODUCTION=1 pod install" 

    This reverts commit 7b088b1.
    @leotm
    leotm committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    1fbf34e View commit details
    Browse the repository at this point in the history

  2. Bake PRODUCTION env var into react_native_pods.rb 

    - PR feedback: #34234 (review)
- Previous Podfile change reverted
    @leotm
    leotm committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    26649db View commit details
    Browse the repository at this point in the history

  3. Update scripts/react_native_pods.rb 

    Thanks figured ^ Appreciate the detailed follow-up

Co-authored-by: Riccardo <riccardo.cipolleschi@gmail.com>
    @leotm @cipolleschi
    leotm and cipolleschi committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    17d17f5 View commit details
    Browse the repository at this point in the history