Cherry picking a couple of fixes from main to 068-stable branch to help fix issues in some brownfield applications

[SparshaSaha]

Summary

There are a couple of fixes in main branch which removes some of the issues faced in brownfield applications.
I plan to cherry-pick these fixes to 0.68-stable branch.

Changelog

1. Added additional builder method receiving arguments for using jsc or hermes to correctly decide which DSO to load at app startup.  #33952 - Added additional builder method receiving arguments for using jsc or hermes to correctly decide which DSO to load at app startup.
2. Logging a soft error when ReactRootView has an id other than -1 instead of crashing the app in hybrid apps. #33133 - Logging a soft error when ReactRootView has an id other than -1 instead of crashing the app in hybrid apps.

[CATEGORY] [TYPE] - Message

Test Plan

Tested locally on our app.

[facebook-github-bot]

Hi @SparshaSaha!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[pull-bot]

	Fails
🚫	node` failed.

Messages

📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message. CATEGORY may be: General iOS Android JavaScript Internal (for changes that do not need to be called out in the release notes) TYPE may be: Added, for new features. Changed, for changes in existing functionality. Deprecated, for soon-to-be removed features. Removed, for now removed features. Fixed, for any bug fixes. Security, in case of vulnerabilities. MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Log

Error:  RequestError [HttpError]: Must have admin rights to Repository.
    at /root/react-native/bots/node_modules/@octokit/request/dist-node/index.js:86:21
    at processTicksAndRejections (internal/process/task_queues.js:95:5) {
  status: 403,
  response: {
    url: 'https://api.github.com/repos/facebook/react-native/issues/34326/labels',
    status: 403,
    headers: {
      'access-control-allow-origin': '*',
      'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset',
      connection: 'close',
      'content-encoding': 'gzip',
      'content-security-policy': "default-src 'none'",
      'content-type': 'application/json; charset=utf-8',
      date: 'Tue, 02 Aug 2022 06:27:26 GMT',
      'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
      server: 'GitHub.com',
      'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
      'transfer-encoding': 'chunked',
      vary: 'Accept-Encoding, Accept, X-Requested-With',
      'x-accepted-oauth-scopes': '',
      'x-content-type-options': 'nosniff',
      'x-frame-options': 'deny',
      'x-github-media-type': 'github.v3; format=json',
      'x-github-request-id': 'D106:5AB4:10F3A:605A7:62E8C3CE',
      'x-oauth-scopes': 'public_repo',
      'x-ratelimit-limit': '5000',
      'x-ratelimit-remaining': '4952',
      'x-ratelimit-reset': '1659422003',
      'x-ratelimit-resource': 'core',
      'x-ratelimit-used': '48',
      'x-xss-protection': '0'
    },
    data: {
      message: 'Must have admin rights to Repository.',
      documentation_url: 'https://docs.github.com/rest/reference/issues#add-labels-to-an-issue'
    }
  },
  request: {
    method: 'POST',
    url: 'https://api.github.com/repos/facebook/react-native/issues/34326/labels',
    headers: {
      accept: 'application/vnd.github.v3+json',
      'user-agent': 'octokit.js/16.43.2 Node.js/14.18.1 (Linux 5.13; x64)',
      authorization: 'token [REDACTED]',
      'content-type': 'application/json; charset=utf-8'
    },
    body: '{"labels":["Pick Request"]}',
    request: { hook: [Function: bound bound register] }
  }
}
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 50cb7ac

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: fc26dbf
Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,124,078	+292,610
android	hermes	armeabi-v7a	7,724,579	+501,939
android	hermes	x86	8,494,176	+350,906
android	hermes	x86_64	8,446,358	+323,482
android	jsc	arm64-v8a	9,789,533	+78,441
android	jsc	armeabi-v7a	8,774,886	+310,388
android	jsc	x86	9,756,235	+95,580
android	jsc	x86_64	10,352,462	+92,377

Base commit: fc26dbf
Branch: main

[danilobuerger]

I don't think thats going to happen like this. If you want something picked, you should post the commit in the respective release discussion. For 0.68.3 it would be reactwg/react-native-releases#22

[kelset]

@danilobuerger I think it's ok in this scenario, this route should help ensure that conflicts during cherry pick are addressed - that said, we are still discussing within the release crew if a new patch release for 0.68 will happen.

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[kelset]

(for future memory, in case you are seeing this:

it's just a GH bug in showing the visuals - Sparsha didn't do anything in RN core, it was on his fork - we are reporting this to GH)