Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Wrapper of InspectorPanel from View to SafeAreaView #34500

Closed
wants to merge 2 commits into from

Conversation

raykle
Copy link
Contributor

@raykle raykle commented Aug 25, 2022

Summary

Currently, the InspectorPanel component is wrapped in View, which is a little difficult to click the panel button when in a device with a notch screen.

Changelog

[General] [Fixed] - Change Wrapper of InspectorPanel from View to SafeAreaView

Test Plan

From:

To:

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Aug 25, 2022
@analysis-bot
Copy link

analysis-bot commented Aug 25, 2022

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,634,491 +0
android hermes armeabi-v7a 7,046,426 +0
android hermes x86 7,936,295 +0
android hermes x86_64 7,908,180 +0
android jsc arm64-v8a 9,511,917 +0
android jsc armeabi-v7a 8,287,198 +0
android jsc x86 9,451,448 +0
android jsc x86_64 10,042,696 +0

Base commit: 361b310
Branch: main

@cipolleschi
Copy link
Contributor

Hi @raykle, could you please rebase your PR?

@raykle raykle requested a review from hramos as a code owner August 27, 2022 05:53
@analysis-bot
Copy link

analysis-bot commented Aug 29, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 81564c1
Branch: main

Copy link
Contributor

@lunaleaps lunaleaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I think there are a lot of changes here unrelated to your PR, either from the rebase or potentially different lints. Can you clean this up to only your changes? Thanks!

@raykle
Copy link
Contributor Author

raykle commented Aug 30, 2022

Hi @lunaleaps, I have rebase the PR.

@raykle raykle requested review from lunaleaps and removed request for hramos August 30, 2022 16:40
Copy link
Contributor

@lunaleaps lunaleaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, was my suggestion wrong? I think we can use es6 imports here no?

@raykle
Copy link
Contributor Author

raykle commented Aug 31, 2022

Hi @lunaleaps , Sorry about that, I'm a little not familiar with the GitHub Pull Request flow, and I clicked the resolve conversation by mistake.

I agree with your suggestion absolutely!
What should I do now? Change the code and push again?

@raykle
Copy link
Contributor Author

raykle commented Aug 31, 2022

modified the code and also rebased it.

@raykle raykle requested a review from lunaleaps August 31, 2022 02:25
@lunaleaps
Copy link
Contributor

Great, thank you!

@facebook-github-bot
Copy link
Contributor

@lunaleaps has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @raykle in afad68f.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants