Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-native-codegen: Enable C++ TurboModule generation in OpenSource builds #35211

Closed

Conversation

christophpurrer
Copy link
Contributor

Summary:
This enables the generation of C++ TurboModule specs in addition to existing Java/ObjC ones.

An example is shown in #35138

Changelog: [Internal]

Differential Revision: D41057630

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Nov 5, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41057630

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,034,677 +39,333
android hermes armeabi-v7a 6,412,135 +40,253
android hermes x86 7,452,257 +44,226
android hermes x86_64 7,313,126 +41,086
android jsc arm64-v8a 8,900,494 +39,335
android jsc armeabi-v7a 7,639,916 +40,245
android jsc x86 8,963,129 +44,225
android jsc x86_64 9,443,332 +41,064

Base commit: f0b7cbe
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41057630

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Nov 5, 2022
… builds (facebook#35211)

Summary:
Pull Request resolved: facebook#35211

This enables the generation of C++ TurboModule specs in addition to existing Java/ObjC ones.

An example is shown in facebook#35138

Changelog: [Internal]

Differential Revision: D41057630

fbshipit-source-id: 5a6199043566d9c081f9a03fef607fed904049a4
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: f0b7cbe
Branch: main

@pull-bot
Copy link

pull-bot commented Nov 5, 2022

PR build artifact for 7824890 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41057630

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Nov 5, 2022
… builds (facebook#35211)

Summary:
Pull Request resolved: facebook#35211

This enables the generation of C++ TurboModule specs in addition to existing Java/ObjC ones.

An example is shown in facebook#35138

Changelog: [Internal]

Differential Revision: D41057630

fbshipit-source-id: 1d2a479cbb29d472fcbc577ed40ebdf02396986e
@pull-bot
Copy link

pull-bot commented Nov 5, 2022

PR build artifact for d8cfce2 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

… builds (facebook#35211)

Summary:
Pull Request resolved: facebook#35211

This enables the generation of C++ TurboModule specs in addition to existing Java/ObjC ones.

An example is shown in facebook#35138

Changelog: [Internal]

Differential Revision: D41057630

fbshipit-source-id: 74d2d1f24bd0dd156cf5268d08af458393e574e3
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41057630

@pull-bot
Copy link

pull-bot commented Nov 5, 2022

PR build artifact for 0229239 is ready.
To use, download tarball from "Artifacts" tab in this CircleCI job then run yarn add <path to tarball> in your React Native project.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @christophpurrer in 35b2150.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Nov 7, 2022
kelset pushed a commit that referenced this pull request Nov 22, 2022
… builds (#35211)

Summary:
Pull Request resolved: #35211

This enables the generation of C++ TurboModule specs in addition to existing Java/ObjC ones.

An example is shown in #35138

Changelog: [Internal]

Reviewed By: cipolleschi

Differential Revision: D41057630

fbshipit-source-id: 303881a63eb82f0fe8dfe10e533043a6eedb3d11
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
… builds (facebook#35211)

Summary:
Pull Request resolved: facebook#35211

This enables the generation of C++ TurboModule specs in addition to existing Java/ObjC ones.

An example is shown in facebook#35138

Changelog: [Internal]

Reviewed By: cipolleschi

Differential Revision: D41057630

fbshipit-source-id: 303881a63eb82f0fe8dfe10e533043a6eedb3d11
@cipolleschi cipolleschi mentioned this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants