fix(release scripts): backport fixes for CI from 0.71 into main #35258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
cipolleschi
approved these changes
Nov 8, 2022
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kelset
changed the title
Base commit: dac6806 |
|
This pull request was successfully merged by @kelset in cfa25e0. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
) Summary: This PR backport two fixes we did in 0.71 to unblock the release process: * the change in `publish-npm` is needed because of the introduction of .strict() from facebook@4f3ca8f * the removal of the other script (added originally here facebook@e4b5d3e) is because: 1) that step is not needed anymore (we don't publish/upload hermes artifacts to the GH release) 2) by the time this job gets run the release crew has already setup the GH release 3) the logic for the versioning was broken and even on the 0.71-rc pipeline it was tagging stuff as 1000.0.0 ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Internal] [Fixed] - Fix release scripts for "release" pipeline scenario Pull Request resolved: facebook#35258 Test Plan: The fact that 0.71-rc0 was released is the ✅ for this. Reviewed By: jacdebug Differential Revision: D41120888 Pulled By: cipolleschi fbshipit-source-id: 06d108f0659ad1db53c6324fe1d735f52c34a3c5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR backport two fixes we did in 0.71 to unblock the release process:
publish-npmis needed because of the introduction of .strict() from 4f3ca8fChangelog
[Internal] [Fixed] - Fix release scripts for "release" pipeline scenario
Test Plan
The fact that 0.71-rc0 was released is the ✅ for this.