[iOS] Implement missing showSoftInputOnFocus prop on TextInput on the new arch

[j-piasecki]

Summary

showSoftInputOnFocus prop was not implemented on the new architecture TextInput component on iOS. I added the implementation based on how it's implemented on the old architecture:

react-native/Libraries/Text/TextInput/RCTBaseTextInputView.m

Lines 313 to 325 in b314e6f

	if (showSoftInputOnFocus) {
	// Resets to default keyboard.
	self.backedTextInputView.inputView = nil;
	// Without the call to reloadInputViews, the keyboard will not change until the textInput field (the first
	// responder) loses and regains focus.
	if (self.backedTextInputView.isFirstResponder) {
	[self.backedTextInputView reloadInputViews];
	}
	} else {
	// Hides keyboard, but keeps blinking cursor.
	self.backedTextInputView.inputView = [UIView new];
	}

Changelog

[IOS] [FIXED] - Added missing showSoftInputOnFocus on TextInput on the new architecture

Test Plan

Added the prop on the TextInput component and checked whether the keyboard opens.

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	18,171,340	-4
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	21,540,480	+5
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: 4c8e253
Branch: main

[philIip]

thank you for working on this!

cc @sammy-SC

[philIip]

why do we couple this logic with multiline? regardless, the initial props should go through the updateProps:oldProps pipeline.

[j-piasecki]

Sorry for the late reply, I must've missed the notification 😅. It's there because setting multiline causes the creation of a new underlying component (either RCTUITextView or RCTUITextField) and we need to apply the showSoftInputOnFocus prop again to the newly created view. Otherwise, it will be reset every time the multiline is set.

[github-actions]

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[github-actions]

	Fails
🚫	📋 Missing Changelog - Please add a Changelog to your PR description. See Changelog format

Generated by 🚫 dangerJS against f0eadd5

[j-piasecki]

Not stale