[Upstream] Pull out CGContext early in UIImage+Diff #35940
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Saadnajmi
changed the title
Base commit: 6f7428e |
matrush
suggested changes
Jan 24, 2023
|
@philIip has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Any update on this? |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: This is a small refactor designed to make future merges for React Native macOS easier. It was found while merging React Native 0.71 into React Native macOS. In React Native macOS, we ifdef iOS out API's and replace them with macOS APIs, reusing as much code as possible. `CGContext` is a type that is available on both iOS and macOS, but `UIGraphicsImageRendererContext` is not. A simple refactor makes it easier to reuse this code in React Native macOS without affecting iOS :) Resolves microsoft#1676 ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [IOS] [CHANGED] - Pull out CGContext early in UIImage+Diff Pull Request resolved: facebook#35940 Test Plan: Build should pass. Reviewed By: matrush Differential Revision: D42761424 Pulled By: javache fbshipit-source-id: 5ce79a5e7c60484dd37d0b2c3f58ff0897d662df
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a small refactor designed to make future merges for React Native macOS easier. It was found while merging React Native 0.71 into React Native macOS.
In React Native macOS, we ifdef iOS out API's and replace them with macOS APIs, reusing as much code as possible.
CGContextis a type that is available on both iOS and macOS, butUIGraphicsImageRendererContextis not. A simple refactor makes it easier to reuse this code in React Native macOS without affecting iOS :)Resolves microsoft#1676
Changelog