RNGP - Bump AGP to 7.4.1 #36039
Closed
RNGP - Bump AGP to 7.4.1 #36039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This change bumps AGP to 7.4.1 so we can remove a lot of the unnecessary changes we had to do to support AGP 7.3.x I've also removed the explicit version in the template as now the AGP version is provided by RNGP. That means that the user will get the correct version they need. This also bumps the default CMake version in user space to 3.22 which resolves a lot of warning when users are building with the New Architecture enabled. Changelog: [Android] [Changed] - Bump AGP to 7.4.1 Differential Revision: D42960353 fbshipit-source-id: ef6e3764c842538b762ae57e85d645f90bf8c89a
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D42960353 |
Base commit: 1e53f88 |
|
This pull request has been merged in 5647d79. |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#36039 This change bumps AGP to 7.4.1 so we can remove a lot of the unnecessary changes we had to do to support AGP 7.3.x I've also removed the explicit version in the template as now the AGP version is provided by RNGP. That means that the user will get the correct version they need. This also bumps the default CMake version in user space to 3.22 which resolves a lot of warning when users are building with the New Architecture enabled. Changelog: [Android] [Changed] - Bump AGP to 7.4.1 allow-large-files Reviewed By: cipolleschi Differential Revision: D42960353 fbshipit-source-id: 9065f975c1694d266a86b2d3fe805e6e2b1c4aa1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change bumps AGP to 7.4.1 so we can remove a lot of the unnecessary changes
we had to do to support AGP 7.3.x
I've also removed the explicit version in the template as now the AGP version
is provided by RNGP. That means that the user will get the correct version they need.
This also bumps the default CMake version in user space to 3.22 which resolves a lot
of warning when users are building with the New Architecture enabled.
Changelog:
[Android] [Changed] - Bump AGP to 7.4.1
Differential Revision: D42960353