Fix ScrollView momentum not stopping when calling scrollTo programmatically

[tomekzaw]

Summary

Fixes #32235.

See #32235 (comment) for details.

Here's what I did:

1. Set a breakpoint in method scrollTo in class android.view.View (make sure the API level of your emulator matches compileSdkVersion so the sources are aligned with the bytecode)
2. Try to scroll the ScrollView, make sure the breakpoint is hit, continue execution
3. Add condition y == 0 to the breakpoint so it doesn't pause execution when scrolling
4. Scroll the ScrollView again so that it still scrolls with its momentum
5. Click the button that calls scrollTo command with y = 0
6. Breakpoint should be hit, see ReactScrollViewCommandHelper in the stack trace
7. Remove condition y == 0 from the breakpoint, continue execution
8. Breakpoint is hit again with y != 0 (in my case 49153 or something) – this is incorrect behavior as it overwrites the effect of the previous call
9. Notice the stack trace goes through a series of native calls, probably there's some mechanism that kicks in here
10. Add mScroller.abortAnimation(); just out of curiosity
11. It actually works!
12. Submit this PR

Before:

recording.mov

After:

after.mov

Changelog

[ANDROID] [FIXED] - Fixed ScrollView momentum not stopping when calling scrollTo programmatically

Test Plan

Reproducer: https://github.com/tomekzaw/Issue32235/blob/master/App.tsx

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,475,963	+62
android	hermes	armeabi-v7a	7,797,634	+69
android	hermes	x86	8,952,068	+68
android	hermes	x86_64	8,809,790	+69
android	jsc	arm64-v8a	9,113,628	-51
android	jsc	armeabi-v7a	8,310,507	-40
android	jsc	x86	9,165,293	-51
android	jsc	x86_64	9,424,096	-42

Base commit: 6d1667c
Branch: main

[facebook-github-bot]

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@cortinico merged this pull request in 681b35d.