Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused LongLivedObject include #36391

Closed
wants to merge 1 commit into from

Conversation

javache
Copy link
Member

@javache javache commented Mar 7, 2023

Summary:
This include isn't required and was causing issues in the Cocoapods build.

Changelog: [iOS] Unbreak cocoapods build

Differential Revision: D43870523

Summary:
This include isn't required and was causing issues in the Cocoapods build.

Changelog: [iOS] Unbreak cocoapods build

Differential Revision: D43870523

fbshipit-source-id: b56fbb8944b48dfd05145fbc9923a1be237516ed
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Mar 7, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43870523

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Fails
🚫

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 11c5177

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,508,039 -2
android hermes armeabi-v7a 7,822,768 -2
android hermes x86 8,986,035 +9
android hermes x86_64 8,842,152 +10
android jsc arm64-v8a 9,134,855 +1
android jsc armeabi-v7a 8,325,173 +8
android jsc x86 9,188,224 +13
android jsc x86_64 9,447,155 +5

Base commit: b73dd67
Branch: main

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Mar 7, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 419025d.

@javache javache deleted the export-D43870523 branch March 8, 2023 12:23
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
Pull Request resolved: facebook#36391

This include isn't required and was causing issues in the Cocoapods build.

Changelog: [iOS][Fixed] Unbreak cocoapods build

Reviewed By: cipolleschi

Differential Revision: D43870523

fbshipit-source-id: 7e31049d19ef025e9e16284712fb2a80dbdf235e
facebook-github-bot pushed a commit that referenced this pull request Nov 8, 2023
Summary:
Similarly to #36391 , we found that this import was periodically causing issues for our builds. We applied this patch and found that it is solving the issue, thus raising the PR here.

It may potentially be related to #35664 and #41281

## Changelog:

[IOS] [FIXED] - Unbreak Cocoapods build

Pull Request resolved: #41368

Test Plan: Automated test builds should be able to spot out potential issues.

Reviewed By: javache

Differential Revision: D51117316

Pulled By: cipolleschi

fbshipit-source-id: 5c8ee35ab38539ae1f5556202bb274566adf09b3
Othinn pushed a commit to Othinn/react-native that referenced this pull request Jan 9, 2024
…k#41368)

Summary:
Similarly to facebook#36391 , we found that this import was periodically causing issues for our builds. We applied this patch and found that it is solving the issue, thus raising the PR here.

It may potentially be related to facebook#35664 and facebook#41281

## Changelog:

[IOS] [FIXED] - Unbreak Cocoapods build

Pull Request resolved: facebook#41368

Test Plan: Automated test builds should be able to spot out potential issues.

Reviewed By: javache

Differential Revision: D51117316

Pulled By: cipolleschi

fbshipit-source-id: 5c8ee35ab38539ae1f5556202bb274566adf09b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants