-
Notifications
You must be signed in to change notification settings - Fork 24k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused LongLivedObject include #36391
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This include isn't required and was causing issues in the Cocoapods build. Changelog: [iOS] Unbreak cocoapods build Differential Revision: D43870523 fbshipit-source-id: b56fbb8944b48dfd05145fbc9923a1be237516ed
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner
fb-exported
labels
Mar 7, 2023
This pull request was exported from Phabricator. Differential Revision: D43870523 |
|
Base commit: b73dd67 |
This pull request has been merged in 419025d. |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#36391 This include isn't required and was causing issues in the Cocoapods build. Changelog: [iOS][Fixed] Unbreak cocoapods build Reviewed By: cipolleschi Differential Revision: D43870523 fbshipit-source-id: 7e31049d19ef025e9e16284712fb2a80dbdf235e
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 8, 2023
Summary: Similarly to #36391 , we found that this import was periodically causing issues for our builds. We applied this patch and found that it is solving the issue, thus raising the PR here. It may potentially be related to #35664 and #41281 ## Changelog: [IOS] [FIXED] - Unbreak Cocoapods build Pull Request resolved: #41368 Test Plan: Automated test builds should be able to spot out potential issues. Reviewed By: javache Differential Revision: D51117316 Pulled By: cipolleschi fbshipit-source-id: 5c8ee35ab38539ae1f5556202bb274566adf09b3
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
…k#41368) Summary: Similarly to facebook#36391 , we found that this import was periodically causing issues for our builds. We applied this patch and found that it is solving the issue, thus raising the PR here. It may potentially be related to facebook#35664 and facebook#41281 ## Changelog: [IOS] [FIXED] - Unbreak Cocoapods build Pull Request resolved: facebook#41368 Test Plan: Automated test builds should be able to spot out potential issues. Reviewed By: javache Differential Revision: D51117316 Pulled By: cipolleschi fbshipit-source-id: 5c8ee35ab38539ae1f5556202bb274566adf09b3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Merged
This PR has been merged.
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This include isn't required and was causing issues in the Cocoapods build.
Changelog: [iOS] Unbreak cocoapods build
Differential Revision: D43870523