Cache Spannables during rendering of Text #36885
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D44918981 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D44918981 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Apr 12, 2023
Summary: Pull Request resolved: facebook#36885 Create cache to hold Spannables during measurment and rendering of Text We used to have a similar cache in the past, it was removed because it seemed not have an implact. We are incorporating this again to measure while rendering 1000s of text components changelog: [internal] internal Reviewed By: cipolleschi Differential Revision: D44918981 fbshipit-source-id: 89f3aa639ad8b01b77da3d8c7a5ea924a43624c8
mdvacca
force-pushed
the
export-D44918981
branch
from
976e05c
to
8f93df5
Compare
Base commit: 846ec6d |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Apr 12, 2023
Summary: Pull Request resolved: facebook#36885 Create cache to hold Spannables during measurment and rendering of Text We used to have a similar cache in the past, it was removed because it seemed not have an implact. We are incorporating this again to measure while rendering 1000s of text components changelog: [internal] internal Reviewed By: cipolleschi Differential Revision: D44918981 fbshipit-source-id: 75aeef4cf9005c40e7145278f339d0b3c4b3cf38
mdvacca
force-pushed
the
export-D44918981
branch
from
8f93df5
to
05d7eac
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44918981 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D44918981 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Apr 12, 2023
Summary: Pull Request resolved: facebook#36885 Create cache to hold Spannables during measurment and rendering of Text We used to have a similar cache in the past, it was removed because it seemed not have an implact. We are incorporating this again to measure while rendering 1000s of text components changelog: [internal] internal Reviewed By: cipolleschi Differential Revision: D44918981 fbshipit-source-id: f473d7e2d58b5dd4cd5963e865a9965e10fe0519
mdvacca
force-pushed
the
export-D44918981
branch
from
05d7eac
to
e6081da
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44918981 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Apr 12, 2023
Summary: Pull Request resolved: facebook#36885 Create cache to hold Spannables during measurment and rendering of Text We used to have a similar cache in the past, it was removed because it seemed not have an implact. We are incorporating this again to measure while rendering 1000s of text components changelog: [internal] internal Reviewed By: cipolleschi Differential Revision: D44918981 fbshipit-source-id: 68add4f5a565991663222d2fa24a43c32f689e85
mdvacca
force-pushed
the
export-D44918981
branch
from
e6081da
to
10bd620
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44918981 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Apr 12, 2023
Summary: Pull Request resolved: facebook#36885 Create cache to hold Spannables during measurment and rendering of Text We used to have a similar cache in the past, it was removed because it seemed not have an implact. We are incorporating this again to measure while rendering 1000s of text components changelog: [internal] internal Reviewed By: cipolleschi Differential Revision: D44918981 fbshipit-source-id: 36d6bfbd3b6291a26006e79aae49d98db7fa7034
mdvacca
force-pushed
the
export-D44918981
branch
from
10bd620
to
b5f280a
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Apr 12, 2023
Summary: Pull Request resolved: facebook#36885 Create cache to hold Spannables during measurment and rendering of Text We used to have a similar cache in the past, it was removed because it seemed not have an implact. We are incorporating this again to measure while rendering 1000s of text components changelog: [internal] internal Reviewed By: cipolleschi Differential Revision: D44918981 fbshipit-source-id: cce8bc4018d493b393cb97902c3193754357480d
mdvacca
force-pushed
the
export-D44918981
branch
from
b5f280a
to
3349c1a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44918981 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D44918981 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Apr 12, 2023
Summary: Pull Request resolved: facebook#36885 Create cache to hold Spannables during measurment and rendering of Text We used to have a similar cache in the past, it was removed because it seemed not have an implact. We are incorporating this again to measure while rendering 1000s of text components changelog: [internal] internal Reviewed By: cipolleschi Differential Revision: D44918981 fbshipit-source-id: fa40f9b963950bb06ee2ba665923023960e65e5b
mdvacca
force-pushed
the
export-D44918981
branch
from
3349c1a
to
dafc66a
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Apr 12, 2023
Summary: Pull Request resolved: facebook#36885 Create cache to hold Spannables during measurment and rendering of Text We used to have a similar cache in the past, it was removed because it seemed not have an implact. We are incorporating this again to measure while rendering 1000s of text components changelog: [internal] internal Reviewed By: cipolleschi Differential Revision: D44918981 fbshipit-source-id: 05472f10f90bfa5f3f8bdadeaf1f578d686e927e
mdvacca
force-pushed
the
export-D44918981
branch
from
dafc66a
to
c4f45f6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44918981 |
Summary: Pull Request resolved: facebook#36885 Create cache to hold Spannables during measurment and rendering of Text We used to have a similar cache in the past, it was removed because it seemed not have an implact. We are incorporating this again to measure while rendering 1000s of text components changelog: [internal] internal Reviewed By: cipolleschi Differential Revision: D44918981 fbshipit-source-id: 0c52a6be28f65c9e71826dd8f0e231844a2ee6ca
|
This pull request was exported from Phabricator. Differential Revision: D44918981 |
mdvacca
force-pushed
the
export-D44918981
branch
from
c4f45f6
to
4a99e54
Compare
|
This pull request has been merged in 9f24df0. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: Pull Request resolved: facebook#36885 Create cache to hold Spannables during measurment and rendering of Text We used to have a similar cache in the past, it was removed because it seemed not have an implact. We are incorporating this again to measure while rendering 1000s of text components changelog: [internal] internal Reviewed By: cipolleschi Differential Revision: D44918981 fbshipit-source-id: 581d22978841e1b62a1709da0fec2baba6c59cea
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#36885 Create cache to hold Spannables during measurment and rendering of Text We used to have a similar cache in the past, it was removed because it seemed not have an implact. We are incorporating this again to measure while rendering 1000s of text components changelog: [internal] internal Reviewed By: cipolleschi Differential Revision: D44918981 fbshipit-source-id: 581d22978841e1b62a1709da0fec2baba6c59cea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Create cache to hold Spannables during measurment and rendering of Text
We used to have a similar cache in the past, it was removed because it seemed not have an implact.
We are incorporating this again to measure while rendering 1000s of text components
changelog: [internal] internal
Differential Revision: D44918981