Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test e2e script #37081

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Fix test e2e script #37081

merged 1 commit into from
Apr 25, 2023

Conversation

fortmarek
Copy link
Contributor

Summary:

This PR fixes the same issues as this one for main did.

Changelog:

[INTERNAL] [FIXED] - Use packaged react-native in test-e2e-local script

Test Plan:

Run ./scripts/test-manual-e2e.sh for RNTestProject –> this script should succeed.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Shopify Partner: Shopify Partner labels Apr 25, 2023
@kelset
Copy link
Contributor

kelset commented Apr 25, 2023 •
edited
Loading

LGTM - let's port it back to 0.69 branch too (via directly cherry-pick once this is squashed&merged)

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 5e983d5
Branch: main

@kelset kelset merged commit 8c90612 into facebook:0.70-stable Apr 25, 2023
1 of 2 checks passed
kelset pushed a commit that referenced this pull request Apr 25, 2023
@fortmarek @kelset
Fix test e2e script (#37081)
4979381
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,600,649 -1,024,248
android hermes armeabi-v7a 7,019,332 -918,200
android hermes x86 7,902,470 -1,209,308
android hermes x86_64 7,874,200 -1,092,431
android jsc arm64-v8a 9,482,299 +293,355
android jsc armeabi-v7a 8,263,056 -115,985
android jsc x86 9,422,252 +175,079
android jsc x86_64 10,013,414 +507,740

Base commit: 5e983d5
Branch: main

kelset pushed a commit that referenced this pull request Apr 25, 2023
@fortmarek @kelset
Fix test e2e script (#37081)
87611d4
@cipolleschi cipolleschi mentioned this pull request Nov 1, 2023
Closed
@cipolleschi cipolleschi mentioned this pull request Dec 19, 2023
Merged
@cipolleschi cipolleschi mentioned this pull request Jan 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelset kelset kelset approved these changes

@cipolleschi cipolleschi Awaiting requested review from cipolleschi

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Shopify Partner: Shopify Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fortmarek @kelset @analysis-bot @facebook-github-bot