Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LOCAL] Fix hermesc for linux #37591

Merged
merged 1 commit into from
May 26, 2023
Merged

[LOCAL] Fix hermesc for linux #37591

merged 1 commit into from
May 26, 2023

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented May 26, 2023 •
edited by kelset

Summary:

Fix hermesc for linux

Changelog:

[internal] - Build the right version of HermesC for linux in CI

Test Plan:

CircleCI is green

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 26, 2023
@cipolleschi cipolleschi changed the base branch from main to 0.72-stable May 26, 2023 12:17
@cipolleschi cipolleschi force-pushed the cipolleschi/fix-hermes-linux branch from 782cb7b to d2a02ad Compare May 26, 2023 12:18
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,546,119 -194,438
android hermes armeabi-v7a 7,860,336 -191,285
android hermes x86 9,025,168 -205,715
android hermes x86_64 8,880,247 -201,983
android jsc arm64-v8a 9,146,015 -157,150
android jsc armeabi-v7a 8,335,985 -155,849
android jsc x86 9,199,395 -165,175
android jsc x86_64 9,457,538 -162,487

Base commit: a244209
Branch: main

kelset
kelset approved these changes May 26, 2023
View reviewed changes
Copy link
Collaborator

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to be working 👍

@kelset kelset changed the title cipolleschi/fix hermes linux [LOCAL] Fix hermesc for linux May 26, 2023
@kelset kelset marked this pull request as ready for review May 26, 2023 12:52
@kelset kelset merged commit 32327cc into 0.72-stable May 26, 2023
17 of 20 checks passed
@kelset kelset deleted the cipolleschi/fix-hermes-linux branch May 26, 2023 12:52
@NOUIY NOUIY mentioned this pull request Jul 13, 2023
Open
This was referenced Aug 10, 2023
Closed
Merged
@cipolleschi cipolleschi mentioned this pull request Sep 21, 2023
Merged
@cipolleschi cipolleschi mentioned this pull request Oct 12, 2023
Merged
@cipolleschi cipolleschi mentioned this pull request Nov 1, 2023
Merged
@stevenpetryk stevenpetryk mentioned this pull request Nov 28, 2023
Merged
@cipolleschi cipolleschi mentioned this pull request Dec 27, 2023
Merged
This was referenced Jan 4, 2024
Merged
Merged
Merged
Closed
This was referenced Feb 28, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelset kelset kelset approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cipolleschi @analysis-bot @kelset @facebook-github-bot