Backporting a fix for hermesc on linux #37596
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D46225179 |
Base commit: 551bbbc |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
May 29, 2023
Summary: Pull Request resolved: facebook#37596 This commit is a backport of this [commit](facebook@32327cc) so that we build the right version of hermes in CI. This also bumps the hermes keys to make sure that we are building it properly from now on. ## Changelog: [Internal] - Fix Hermes versioning and bump hermes workspace keys Reviewed By: cortinico Differential Revision: D46225179 fbshipit-source-id: 535b694361f8e6576c6639b66d0ef4f23002a92a
cipolleschi
force-pushed
the
export-D46225179
branch
from
d4745ff
to
0fbb87e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46225179 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D46225179 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
May 30, 2023
Summary: Pull Request resolved: facebook#37596 This commit is a backport of this [commit](facebook@32327cc) so that we build the right version of hermes in CI. This also bumps the hermes keys to make sure that we are building it properly from now on. ## Changelog: [Internal] - Fix Hermes versioning and bump hermes workspace keys Reviewed By: cortinico Differential Revision: D46225179 fbshipit-source-id: ddb4b58356a8bca5573a3724a9b2214deac4ae92
cipolleschi
force-pushed
the
export-D46225179
branch
from
0fbb87e
to
0ddc198
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
May 30, 2023
Summary: Pull Request resolved: facebook#37596 This commit is a backport of this [commit](facebook@32327cc) so that we build the right version of hermes in CI. This also bumps the hermes keys to make sure that we are building it properly from now on. ## Changelog: [Internal] - Fix Hermes versioning and bump hermes workspace keys Reviewed By: cortinico Differential Revision: D46225179 fbshipit-source-id: 759dd6d5424386942f164f94f0ae6fe56d99c051
cipolleschi
force-pushed
the
export-D46225179
branch
from
0ddc198
to
6313cdf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46225179 |
Summary: Pull Request resolved: facebook#37596 This commit is a backport of this [commit](facebook@32327cc) so that we build the right version of hermes in CI. This also bumps the hermes keys to make sure that we are building it properly from now on. ## Changelog: [Internal] - Fix Hermes versioning and bump hermes workspace keys Reviewed By: cortinico Differential Revision: D46225179 fbshipit-source-id: a62fda7f417f69aee7fb8e1d812b02fda694f534
cipolleschi
force-pushed
the
export-D46225179
branch
from
6313cdf
to
7cffe74
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46225179 |
|
This pull request has been merged in 323b7f8. |
Szymon20000
pushed a commit
to Szymon20000/react-native
that referenced
this pull request
Jun 14, 2023
Summary: Pull Request resolved: facebook#37596 This commit is a backport of this [commit](facebook@32327cc) so that we build the right version of hermes in CI. This also bumps the hermes keys to make sure that we are building it properly from now on. ## Changelog: [Internal] - Fix Hermes versioning and bump hermes workspace keys Reviewed By: cortinico Differential Revision: D46225179 fbshipit-source-id: f00c9d20d37f3bd5689e0742063f98e3bfe373c2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This commit is a backport of this commit so that we build the right version of hermes in CI.
This also bumps the hermes keys to make sure that we are building it properly from now on.
Changelog:
[Internal] - Fix Hermes versioning and bump hermes workspace keys
Differential Revision: D46225179