Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LOCAL] Set kotlin.jvm.target.validation.mode=warning on user projects #37869

Merged
merged 1 commit into from
Jun 14, 2023
Merged

[LOCAL] Set kotlin.jvm.target.validation.mode=warning on user projects #37869

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...act-native-gradle-plugin/src/main/kotlin/com/facebook/react/utils/JdkConfiguratorUtils.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,5 +36,11 @@ internal object JdkConfiguratorUtils {
project.pluginManager.withPlugin("com.android.application", action)
project.pluginManager.withPlugin("com.android.library", action)
}
// We set kotlin.jvm.target.validation.mode=warning on the root projects, as for projects
// on Gradle 8+ and Kotlin 1.8+ this value is set to `error`. This will cause the build to
// fail if the JDK version between compileKotlin and compileJava and jvmTarget are not
// aligned. This won't be necessary anymore from React Native 0.73. More on this:
// https://kotlinlang.org/docs/whatsnew18.html#obligatory-check-for-jvm-targets-of-related-kotlin-and-java-compile-tasks
input.rootProject.extensions.extraProperties.set("kotlin.jvm.target.validation.mode", "warning")
}
}