Bump formatters to the latest major versions #38545
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…next major version
facebook-github-bot
added
CLA Signed
Base commit: eb661df |
github-actions
bot
added
the
Needs: Repro
drewxs
reviewed
Jul 25, 2023
cortinico
removed
the
Needs: Repro
# Conflicts: # .flowconfig # .flowconfig.android # package.json # packages/eslint-config-react-native/package.json # packages/react-native/template/package.json # yarn.lock
# Conflicts: # package.json
# Conflicts: # yarn.lock
# Conflicts: # package.json
# Conflicts: # package.json # packages/eslint-config-react-native/package.json # yarn.lock
# Conflicts: # yarn.lock
# Conflicts: # package.json
# Conflicts: # package.json
# Conflicts: # packages/react-native-codegen/package.json
# Conflicts: # package.json
|
Just a small heads up as this PR has been un-reviewed for a while. Sadly we can't just bump prettier easily as we'll have to follow the versioning imposed by the internal monorepo. So once we bump prettier internally, React Native will also be bumped |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Prettier v3 has been released recently and has caused compatibility issues with
eslint-plugin-prettier, which released v5 shortly afterwards to resolve the conflict. However,@react-native/eslint-configis still consumingeslint-plugin-prettier@^4.2.1, so any project that has upgraded Prettier to v3 will see exceptions while linting.In light of the fact that several formatters (Prettier, eslint-plugin-prettier, typescript-eslint) have recently made major-version releases, I recommend upgrading them to mitigate potential issues and leverage the latest updates of the formatters.
Changelog:
[GENERAL] [CHANGED] - Bump Prettier in template from 2.8.8 to 3.0.0 and upgrade dependencies of
@react-native/eslint-configTest Plan:
Everything builds and runs as expected