Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate CompositeReactPackage #39565

Closed
wants to merge 1 commit into from

Conversation

mdvacca
Copy link
Contributor

@mdvacca mdvacca commented Sep 20, 2023

Summary:
CompositeReactPackage is not used at Meta neither in github public repositories, we are deprecating it in v0.73 with the goal to remove it in v0.74

changelog: [Android][Breaking] Deprecate CompositeReactPackage from RN Android

Reviewed By: christophpurrer

Differential Revision: D49440130

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Sep 20, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49440130

@github-actions
Copy link

github-actions bot commented Sep 20, 2023

Warnings
⚠️ One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against 8166fc5

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49440130

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 21, 2023
Summary:
Pull Request resolved: facebook#39565

CompositeReactPackage is not used at Meta neither in github public repositories, we are deprecating it in v0.73 with the goal to remove it in v0.74

changelog: [Android][Breaking] Deprecate CompositeReactPackage from RN Android

Reviewed By: christophpurrer

Differential Revision: D49440130

fbshipit-source-id: 568a7295ca9422603ac218b3610bfdbff574052b
mdvacca added a commit to mdvacca/react-native that referenced this pull request Oct 1, 2023
Summary:

CompositeReactPackage is not used at Meta neither in github public repositories, we are deprecating it in v0.73 with the goal to remove it in v0.74



changelog: [Android][Breaking] Deprecate CompositeReactPackage from RN Android

Reviewed By: christophpurrer

Differential Revision: D49440130
mdvacca added a commit to mdvacca/react-native that referenced this pull request Oct 1, 2023
Summary:

CompositeReactPackage is not used at Meta neither in github public repositories, we are deprecating it in v0.73 with the goal to remove it in v0.74



changelog: [Android][Breaking] Deprecate CompositeReactPackage from RN Android

Reviewed By: christophpurrer

Differential Revision: D49440130
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49440130

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49440130

mdvacca added a commit to mdvacca/react-native that referenced this pull request Oct 1, 2023
Summary:

CompositeReactPackage is not used at Meta neither in github public repositories, we are deprecating it in v0.73 with the goal to remove it in v0.74



changelog: [Android][Breaking] Deprecate CompositeReactPackage from RN Android

Reviewed By: christophpurrer

Differential Revision: D49440130
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49440130

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49440130

Summary:

CompositeReactPackage is not used at Meta neither in github public repositories, we are deprecating it in v0.73 with the goal to remove it in v0.74



changelog: [Android][Breaking] Deprecate CompositeReactPackage from RN Android

Reviewed By: christophpurrer

Differential Revision: D49440130
mdvacca added a commit to mdvacca/react-native that referenced this pull request Oct 1, 2023
Summary:

CompositeReactPackage is not used at Meta neither in github public repositories, we are deprecating it in v0.73 with the goal to remove it in v0.74



changelog: [Android][Breaking] Deprecate CompositeReactPackage from RN Android

Reviewed By: christophpurrer

Differential Revision: D49440130
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49440130

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,902,922 +12
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,381,655 -4
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: d95433f
Branch: main

@github-actions github-actions bot added the Merged This PR has been merged. label Oct 1, 2023
@github-actions
Copy link

github-actions bot commented Oct 1, 2023

This pull request was successfully merged by @mdvacca in 294c0fa.

When will my fix make it into a release? | Upcoming Releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants