Remove Yoga-internal.h #41346
Closed
Remove Yoga-internal.h #41346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51014340 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/react-native#41346 This removes the last remnant from `Yoga-interna.h`, `YGNodeDellocate()`. The API is renamed to `YGNodeFinalize` to give it the explicit purpose of freeing the node from a garbage collector, and made public with that documented contract. With that, every top-level header is now a public API, and Yoga's JNI bindings do not need to rely on private headers anymore. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D51014340
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/yoga#1452 This removes the last remnant from `Yoga-interna.h`, `YGNodeDellocate()`. The API is renamed to `YGNodeFinalize` to give it the explicit purpose of freeing the node from a garbage collector, and made public with that documented contract. With that, every top-level header is now a public API, and Yoga's JNI bindings do not need to rely on private headers anymore. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D51014340
NickGerleman
force-pushed
the
export-D51014340
branch
from
c674ffc
to
3926d6e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51014340 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/react-native#41346 This removes the last remnant from `Yoga-interna.h`, `YGNodeDellocate()`. The API is renamed to `YGNodeFinalize` to give it the explicit purpose of freeing the node from a garbage collector, and made public with that documented contract. With that, every top-level header is now a public API, and Yoga's JNI bindings do not need to rely on private headers anymore. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D51014340
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/yoga#1452 This removes the last remnant from `Yoga-interna.h`, `YGNodeDellocate()`. The API is renamed to `YGNodeFinalize` to give it the explicit purpose of freeing the node from a garbage collector, and made public with that documented contract. With that, every top-level header is now a public API, and Yoga's JNI bindings do not need to rely on private headers anymore. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D51014340
NickGerleman
force-pushed
the
export-D51014340
branch
from
3926d6e
to
bea4327
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51014340 |
Base commit: 5f65f21 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/react-native#41346 This removes the last remnant from `Yoga-interna.h`, `YGNodeDellocate()`. The API is renamed to `YGNodeFinalize` to give it the explicit purpose of freeing the node from a garbage collector, and made public with that documented contract. With that, every top-level header is now a public API, and Yoga's JNI bindings do not need to rely on private headers anymore. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D51014340
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/yoga#1452 This removes the last remnant from `Yoga-interna.h`, `YGNodeDellocate()`. The API is renamed to `YGNodeFinalize` to give it the explicit purpose of freeing the node from a garbage collector, and made public with that documented contract. With that, every top-level header is now a public API, and Yoga's JNI bindings do not need to rely on private headers anymore. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D51014340
NickGerleman
force-pushed
the
export-D51014340
branch
from
bea4327
to
6255a5b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51014340 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/react-native#41346 This removes the last remnant from `Yoga-interna.h`, `YGNodeDellocate()`. The API is renamed to `YGNodeFinalize` to give it the explicit purpose of freeing the node from a garbage collector, and made public with that documented contract. With that, every top-level header is now a public API, and Yoga's JNI bindings do not need to rely on private headers anymore. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D51014340
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/yoga#1452 This removes the last remnant from `Yoga-interna.h`, `YGNodeDellocate()`. The API is renamed to `YGNodeFinalize` to give it the explicit purpose of freeing the node from a garbage collector, and made public with that documented contract. With that, every top-level header is now a public API, and Yoga's JNI bindings do not need to rely on private headers anymore. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D51014340
NickGerleman
force-pushed
the
export-D51014340
branch
from
6255a5b
to
e122786
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51014340 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/react-native#41346 This removes the last remnant from `Yoga-interna.h`, `YGNodeDellocate()`. The API is renamed to `YGNodeFinalize` to give it the explicit purpose of freeing the node from a garbage collector, and made public with that documented contract. With that, every top-level header is now a public API, and Yoga's JNI bindings do not need to rely on private headers anymore. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D51014340
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/yoga#1452 This removes the last remnant from `Yoga-interna.h`, `YGNodeDellocate()`. The API is renamed to `YGNodeFinalize` to give it the explicit purpose of freeing the node from a garbage collector, and made public with that documented contract. With that, every top-level header is now a public API, and Yoga's JNI bindings do not need to rely on private headers anymore. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D51014340
NickGerleman
force-pushed
the
export-D51014340
branch
from
e122786
to
1de01e0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51014340 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/react-native#41346 This removes the last remnant from `Yoga-interna.h`, `YGNodeDellocate()`. The API is renamed to `YGNodeFinalize` to give it the explicit purpose of freeing the node from a garbage collector, and made public with that documented contract. With that, every top-level header is now a public API, and Yoga's JNI bindings do not need to rely on private headers anymore. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D51014340
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/yoga#1452 This removes the last remnant from `Yoga-interna.h`, `YGNodeDellocate()`. The API is renamed to `YGNodeFinalize` to give it the explicit purpose of freeing the node from a garbage collector, and made public with that documented contract. With that, every top-level header is now a public API, and Yoga's JNI bindings do not need to rely on private headers anymore. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D51014340
NickGerleman
force-pushed
the
export-D51014340
branch
from
1de01e0
to
62b4e66
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51014340 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/react-native#41346 This removes the last remnant from `Yoga-interna.h`, `YGNodeDellocate()`. The API is renamed to `YGNodeFinalize` to give it the explicit purpose of freeing the node from a garbage collector, and made public with that documented contract. With that, every top-level header is now a public API, and Yoga's JNI bindings do not need to rely on private headers anymore. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D51014340
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/yoga#1452 This removes the last remnant from `Yoga-interna.h`, `YGNodeDellocate()`. The API is renamed to `YGNodeFinalize` to give it the explicit purpose of freeing the node from a garbage collector, and made public with that documented contract. With that, every top-level header is now a public API, and Yoga's JNI bindings do not need to rely on private headers anymore. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D51014340
NickGerleman
force-pushed
the
export-D51014340
branch
from
62b4e66
to
84a46ca
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51014340 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/react-native#41346 This removes the last remnant from `Yoga-interna.h`, `YGNodeDellocate()`. The API is renamed to `YGNodeFinalize` to give it the explicit purpose of freeing the node from a garbage collector, and made public with that documented contract. With that, every top-level header is now a public API, and Yoga's JNI bindings do not need to rely on private headers anymore. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D51014340
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/yoga#1452 This removes the last remnant from `Yoga-interna.h`, `YGNodeDellocate()`. The API is renamed to `YGNodeFinalize` to give it the explicit purpose of freeing the node from a garbage collector, and made public with that documented contract. With that, every top-level header is now a public API, and Yoga's JNI bindings do not need to rely on private headers anymore. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D51014340
NickGerleman
force-pushed
the
export-D51014340
branch
from
84a46ca
to
df66e73
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51014340 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/react-native#41346 This removes the last remnant from `Yoga-interna.h`, `YGNodeDellocate()`. The API is renamed to `YGNodeFinalize` to give it the explicit purpose of freeing the node from a garbage collector, and made public with that documented contract. With that, every top-level header is now a public API, and Yoga's JNI bindings do not need to rely on private headers anymore. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D51014340
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/yoga#1452 This removes the last remnant from `Yoga-interna.h`, `YGNodeDellocate()`. The API is renamed to `YGNodeFinalize` to give it the explicit purpose of freeing the node from a garbage collector, and made public with that documented contract. With that, every top-level header is now a public API, and Yoga's JNI bindings do not need to rely on private headers anymore. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D51014340
NickGerleman
force-pushed
the
export-D51014340
branch
from
df66e73
to
6cfaf73
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51014340 |
Summary: X-link: facebook/yoga#1448 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
Summary: X-link: facebook/yoga#1452 This removes the last remnant from `Yoga-interna.h`, `YGNodeDellocate()`. The API is renamed to `YGNodeFinalize` to give it the explicit purpose of freeing the node from a garbage collector, and made public with that documented contract. With that, every top-level header is now a public API, and Yoga's JNI bindings do not need to rely on private headers anymore. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D51014340
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 8, 2023
Summary: X-link: facebook/react-native#41346 This removes the last remnant from `Yoga-interna.h`, `YGNodeDellocate()`. The API is renamed to `YGNodeFinalize` to give it the explicit purpose of freeing the node from a garbage collector, and made public with that documented contract. With that, every top-level header is now a public API, and Yoga's JNI bindings do not need to rely on private headers anymore. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D51014340
NickGerleman
force-pushed
the
export-D51014340
branch
from
6cfaf73
to
7ce6ca1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51014340 |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Nov 8, 2023
Summary: X-link: facebook/react-native#41346 X-link: facebook/yoga#1452 This removes the last remnant from `Yoga-interna.h`, `YGNodeDellocate()`. The API is renamed to `YGNodeFinalize` to give it the explicit purpose of freeing the node from a garbage collector, and made public with that documented contract. With that, every top-level header is now a public API, and Yoga's JNI bindings do not need to rely on private headers anymore. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D51014340 fbshipit-source-id: 553f04b62c78b76f9102cd6197146650955aeec5
|
This pull request has been merged in 5a7ae61. |
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Nov 8, 2023
Summary: X-link: facebook/react-native#41346 Pull Request resolved: #1452 This removes the last remnant from `Yoga-interna.h`, `YGNodeDellocate()`. The API is renamed to `YGNodeFinalize` to give it the explicit purpose of freeing the node from a garbage collector, and made public with that documented contract. With that, every top-level header is now a public API, and Yoga's JNI bindings do not need to rely on private headers anymore. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D51014340 fbshipit-source-id: 553f04b62c78b76f9102cd6197146650955aeec5
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#41346 X-link: facebook/yoga#1452 This removes the last remnant from `Yoga-interna.h`, `YGNodeDellocate()`. The API is renamed to `YGNodeFinalize` to give it the explicit purpose of freeing the node from a garbage collector, and made public with that documented contract. With that, every top-level header is now a public API, and Yoga's JNI bindings do not need to rely on private headers anymore. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D51014340 fbshipit-source-id: 553f04b62c78b76f9102cd6197146650955aeec5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This removes the last remnant from
Yoga-interna.h,YGNodeDellocate(). The API is renamed toYGNodeFinalizeto give it the explicit purpose of freeing the node from a garbage collector, and made public with that documented contract.With that, every top-level header is now a public API, and Yoga's JNI bindings do not need to rely on private headers anymore.
Changelog: [Internal]
Differential Revision: D51014340