Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix catalyst + use_frameworks build w/header change in React-RCTFabric.podspec #41371

Closed
wants to merge 1 commit into from

Conversation

mikehardy
Copy link
Contributor

Summary:

react-native 0.73 had a compile regression for macCatalyst builds with use_frameworks

There was some investigation on discord and with all credit to @cipolleschi for this header path fix, the build appears to work with this change

Changelog:

[IOS] [FIXED] - Fixed catalyst build regression in use_frameworks context

Test Plan:

I have a demonstration script that checks use_frameworks builds for ios debug, ios release and macCatalyst, it detected the problem and confirmed the fix: https://github.com/mikehardy/rnfbdemo/commits/rn73-catalyst

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. sony Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Nov 8, 2023
@cipolleschi
Copy link
Contributor

As discussed in other forums, this has been superseded by a bigger effort to make RN more scalable with other Apple platforms. See this PR for reference.

@cipolleschi cipolleschi closed this Nov 8, 2023
@mikehardy mikehardy deleted the patch-1 branch November 8, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants