Refactor generate-artifacts-executor.js: delete configFilename and configKey arguments #41533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51256486 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 17, 2023
…nfigKey arguments (facebook#41533) Summary: This diff removes `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. ## Motivation The existing implementation expects every library to have its codegen config in a file with `configFilename` name. `configFilename` is passed as a single CLI argument and applied to every app dependency. I.e. if `configFilename = codegen.config.json` then we expect to find this file in *every* third-party library. That is weird expectation. This customisation option is unsound. Same with `configKey`. It is much simpler to just stick with convention that `configFilename = "package.json"` and `configKey = "codegenConfig"`. Changelog: [General][Breaking] - Delete `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. Differential Revision: D51256486
Base commit: d1e03f5 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 17, 2023
…nfigKey arguments (facebook#41533) Summary: This diff removes `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. ## Motivation The existing implementation expects every library to have its codegen config in a file with `configFilename` name. `configFilename` is passed as a single CLI argument and applied to every app dependency. I.e. if `configFilename = codegen.config.json` then we expect to find this file in *every* third-party library. That is weird expectation. This customisation option is unsound. Same with `configKey`. It is much simpler to just stick with convention that `configFilename = "package.json"` and `configKey = "codegenConfig"`. Changelog: [General][Breaking] - Delete `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. Differential Revision: D51256486
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2023
…nfigKey arguments (facebook#41533) Summary: This diff removes `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. ## Motivation The existing implementation expects every library to have its codegen config in a file with `configFilename` name. `configFilename` is passed as a single CLI argument and applied to every app dependency. I.e. if `configFilename = codegen.config.json` then we expect to find this file in *every* third-party library. That is weird expectation. This customisation option is unsound. Same with `configKey`. It is much simpler to just stick with convention that `configFilename = "package.json"` and `configKey = "codegenConfig"`. Changelog: [General][Breaking] - Delete `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. Reviewed By: cipolleschi Differential Revision: D51256486
dmytrorykun
force-pushed
the
export-D51256486
branch
from
c751098
to
c13dece
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51256486 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2023
…nfigKey arguments (facebook#41533) Summary: This diff removes `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. ## Motivation The existing implementation expects every library to have its codegen config in a file with `configFilename` name. `configFilename` is passed as a single CLI argument and applied to every app dependency. I.e. if `configFilename = codegen.config.json` then we expect to find this file in *every* third-party library. That is weird expectation. This customisation option is unsound. Same with `configKey`. It is much simpler to just stick with convention that `configFilename = "package.json"` and `configKey = "codegenConfig"`. Changelog: [General][Breaking] - Delete `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. Reviewed By: cipolleschi Differential Revision: D51256486
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2023
…nfigKey arguments (facebook#41533) Summary: This diff removes `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. ## Motivation The existing implementation expects every library to have its codegen config in a file with `configFilename` name. `configFilename` is passed as a single CLI argument and applied to every app dependency. I.e. if `configFilename = codegen.config.json` then we expect to find this file in *every* third-party library. That is weird expectation. This customisation option is unsound. Same with `configKey`. It is much simpler to just stick with convention that `configFilename = "package.json"` and `configKey = "codegenConfig"`. Changelog: [General][Breaking] - Delete `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. Reviewed By: cipolleschi Differential Revision: D51256486
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2023
…nfigKey arguments (facebook#41533) Summary: Pull Request resolved: facebook#41533 This diff removes `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. ## Motivation The existing implementation expects every library to have its codegen config in a file with `configFilename` name. `configFilename` is passed as a single CLI argument and applied to every app dependency. I.e. if `configFilename = codegen.config.json` then we expect to find this file in *every* third-party library. That is weird expectation. This customisation option is unsound. Same with `configKey`. It is much simpler to just stick with convention that `configFilename = "package.json"` and `configKey = "codegenConfig"`. Changelog: [General][Breaking] - Delete `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. Differential Revision: https://internalfb.com/D51256486 fbshipit-source-id: 99774cd06c2340b76dac1e4179fc41145ced9b4a
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2023
…nfigKey arguments (facebook#41533) Summary: Pull Request resolved: facebook#41533 This diff removes `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. ## Motivation The existing implementation expects every library to have its codegen config in a file with `configFilename` name. `configFilename` is passed as a single CLI argument and applied to every app dependency. I.e. if `configFilename = codegen.config.json` then we expect to find this file in *every* third-party library. That is weird expectation. This customisation option is unsound. Same with `configKey`. It is much simpler to just stick with convention that `configFilename = "package.json"` and `configKey = "codegenConfig"`. Changelog: [General][Breaking] - Delete `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. Differential Revision: https://internalfb.com/D51256486 fbshipit-source-id: 330c4cb9f686a5e5cdc8a9805b5991addc1fe463
|
This pull request was exported from Phabricator. Differential Revision: D51256486 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2023
…nfigKey arguments (facebook#41533) Summary: Pull Request resolved: facebook#41533 This diff removes `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. ## Motivation The existing implementation expects every library to have its codegen config in a file with `configFilename` name. `configFilename` is passed as a single CLI argument and applied to every app dependency. I.e. if `configFilename = codegen.config.json` then we expect to find this file in *every* third-party library. That is weird expectation. This customisation option is unsound. Same with `configKey`. It is much simpler to just stick with convention that `configFilename = "package.json"` and `configKey = "codegenConfig"`. Changelog: [General][Breaking] - Delete `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. Reviewed By: cipolleschi Differential Revision: D51256486 fbshipit-source-id: 0700910be00e5e7733ae8ff889205a2f81a3110d
dmytrorykun
force-pushed
the
export-D51256486
branch
from
c13dece
to
46cb8fe
Compare
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2023
…nfigKey arguments (facebook#41533) Summary: Pull Request resolved: facebook#41533 This diff removes `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. ## Motivation The existing implementation expects every library to have its codegen config in a file with `configFilename` name. `configFilename` is passed as a single CLI argument and applied to every app dependency. I.e. if `configFilename = codegen.config.json` then we expect to find this file in *every* third-party library. That is weird expectation. This customisation option is unsound. Same with `configKey`. It is much simpler to just stick with convention that `configFilename = "package.json"` and `configKey = "codegenConfig"`. Changelog: [General][Breaking] - Delete `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. Differential Revision: https://internalfb.com/D51256486 fbshipit-source-id: 499e355666463446ee4e50e9e2cbc2b37025428a
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2023
…nfigKey arguments (facebook#41533) Summary: Pull Request resolved: facebook#41533 This diff removes `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. ## Motivation The existing implementation expects every library to have its codegen config in a file with `configFilename` name. `configFilename` is passed as a single CLI argument and applied to every app dependency. I.e. if `configFilename = codegen.config.json` then we expect to find this file in *every* third-party library. That is weird expectation. This customisation option is unsound. Same with `configKey`. It is much simpler to just stick with convention that `configFilename = "package.json"` and `configKey = "codegenConfig"`. Changelog: [General][Breaking] - Delete `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. Differential Revision: https://internalfb.com/D51256486 fbshipit-source-id: 6b6124605dfd56c64752e5b9cdd2f606dbfaa13e
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2023
…nfigKey arguments (facebook#41533) Summary: Pull Request resolved: facebook#41533 This diff removes `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. ## Motivation The existing implementation expects every library to have its codegen config in a file with `configFilename` name. `configFilename` is passed as a single CLI argument and applied to every app dependency. I.e. if `configFilename = codegen.config.json` then we expect to find this file in *every* third-party library. That is weird expectation. This customisation option is unsound. Same with `configKey`. It is much simpler to just stick with convention that `configFilename = "package.json"` and `configKey = "codegenConfig"`. Changelog: [General][Breaking] - Delete `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. Differential Revision: https://internalfb.com/D51256486 fbshipit-source-id: 815ecd3f10f4f9bd9b8f2d23f1fc707bef866ade
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2023
…nfigKey arguments (facebook#41533) Summary: Pull Request resolved: facebook#41533 This diff removes `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. ## Motivation The existing implementation expects every library to have its codegen config in a file with `configFilename` name. `configFilename` is passed as a single CLI argument and applied to every app dependency. I.e. if `configFilename = codegen.config.json` then we expect to find this file in *every* third-party library. That is weird expectation. This customisation option is unsound. Same with `configKey`. It is much simpler to just stick with convention that `configFilename = "package.json"` and `configKey = "codegenConfig"`. Changelog: [General][Breaking] - Delete `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. Differential Revision: https://internalfb.com/D51256486 fbshipit-source-id: da34bcc341f9d0501138f22b62cd373645779b9f
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2023
…nfigKey arguments (facebook#41533) Summary: Pull Request resolved: facebook#41533 This diff removes `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. ## Motivation The existing implementation expects every library to have its codegen config in a file with `configFilename` name. `configFilename` is passed as a single CLI argument and applied to every app dependency. I.e. if `configFilename = codegen.config.json` then we expect to find this file in *every* third-party library. That is weird expectation. This customisation option is unsound. Same with `configKey`. It is much simpler to just stick with convention that `configFilename = "package.json"` and `configKey = "codegenConfig"`. Changelog: [General][Breaking] - Delete `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. Differential Revision: https://internalfb.com/D51256486 fbshipit-source-id: cd073c74da1ffbb5b26af7994957148a0fff446d
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2023
…nfigKey arguments (facebook#41533) Summary: Pull Request resolved: facebook#41533 This diff removes `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. ## Motivation The existing implementation expects every library to have its codegen config in a file with `configFilename` name. `configFilename` is passed as a single CLI argument and applied to every app dependency. I.e. if `configFilename = codegen.config.json` then we expect to find this file in *every* third-party library. That is weird expectation. This customisation option is unsound. Same with `configKey`. It is much simpler to just stick with convention that `configFilename = "package.json"` and `configKey = "codegenConfig"`. Changelog: [General][Breaking] - Delete `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. Differential Revision: https://internalfb.com/D51256486 fbshipit-source-id: 4300693793a0336b9020dd4164a4468151da1e4d
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2023
…nfigKey arguments (facebook#41533) Summary: Pull Request resolved: facebook#41533 This diff removes `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. ## Motivation The existing implementation expects every library to have its codegen config in a file with `configFilename` name. `configFilename` is passed as a single CLI argument and applied to every app dependency. I.e. if `configFilename = codegen.config.json` then we expect to find this file in *every* third-party library. That is weird expectation. This customisation option is unsound. Same with `configKey`. It is much simpler to just stick with convention that `configFilename = "package.json"` and `configKey = "codegenConfig"`. Changelog: [General][Breaking] - Delete `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. Differential Revision: https://internalfb.com/D51256486 fbshipit-source-id: 7d8ff60c11e7761007b091c63d8c2040c9e5e706
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2023
…nfigKey arguments (facebook#41533) Summary: This diff removes `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. ## Motivation The existing implementation expects every library to have its codegen config in a file with `configFilename` name. `configFilename` is passed as a single CLI argument and applied to every app dependency. I.e. if `configFilename = codegen.config.json` then we expect to find this file in *every* third-party library. That is weird expectation. This customisation option is unsound. Same with `configKey`. It is much simpler to just stick with convention that `configFilename = "package.json"` and `configKey = "codegenConfig"`. Changelog: [General][Breaking] - Delete `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. Reviewed By: cipolleschi Differential Revision: D51256486
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2023
…nfigKey arguments (facebook#41533) Summary: This diff removes `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. ## Motivation The existing implementation expects every library to have its codegen config in a file with `configFilename` name. `configFilename` is passed as a single CLI argument and applied to every app dependency. I.e. if `configFilename = codegen.config.json` then we expect to find this file in *every* third-party library. That is weird expectation. This customisation option is unsound. Same with `configKey`. It is much simpler to just stick with convention that `configFilename = "package.json"` and `configKey = "codegenConfig"`. Changelog: [General][Breaking] - Delete `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. Reviewed By: cipolleschi Differential Revision: D51256486
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2023
…nfigKey arguments (facebook#41533) Summary: Pull Request resolved: facebook#41533 This diff removes `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. ## Motivation The existing implementation expects every library to have its codegen config in a file with `configFilename` name. `configFilename` is passed as a single CLI argument and applied to every app dependency. I.e. if `configFilename = codegen.config.json` then we expect to find this file in *every* third-party library. That is weird expectation. This customisation option is unsound. Same with `configKey`. It is much simpler to just stick with convention that `configFilename = "package.json"` and `configKey = "codegenConfig"`. Changelog: [General][Breaking] - Delete `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. Differential Revision: https://internalfb.com/D51256486 fbshipit-source-id: b484f7c75594d820ba933a39af9f679672613f70
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2023
…nfigKey arguments (facebook#41533) Summary: Pull Request resolved: facebook#41533 This diff removes `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. ## Motivation The existing implementation expects every library to have its codegen config in a file with `configFilename` name. `configFilename` is passed as a single CLI argument and applied to every app dependency. I.e. if `configFilename = codegen.config.json` then we expect to find this file in *every* third-party library. That is weird expectation. This customisation option is unsound. Same with `configKey`. It is much simpler to just stick with convention that `configFilename = "package.json"` and `configKey = "codegenConfig"`. Changelog: [General][Breaking] - Delete `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. Differential Revision: https://internalfb.com/D51256486 fbshipit-source-id: de822b4930e41ae2157c3bae6db19f15b10c8049
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2023
…nfigKey arguments (facebook#41533) Summary: This diff removes `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. ## Motivation The existing implementation expects every library to have its codegen config in a file with `configFilename` name. `configFilename` is passed as a single CLI argument and applied to every app dependency. I.e. if `configFilename = codegen.config.json` then we expect to find this file in *every* third-party library. That is weird expectation. This customisation option is unsound. Same with `configKey`. It is much simpler to just stick with convention that `configFilename = "package.json"` and `configKey = "codegenConfig"`. Changelog: [General][Breaking] - Delete `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. Reviewed By: cipolleschi Differential Revision: D51256486
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2023
…nfigKey arguments (facebook#41533) Summary: This diff removes `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. ## Motivation The existing implementation expects every library to have its codegen config in a file with `configFilename` name. `configFilename` is passed as a single CLI argument and applied to every app dependency. I.e. if `configFilename = codegen.config.json` then we expect to find this file in *every* third-party library. That is weird expectation. This customisation option is unsound. Same with `configKey`. It is much simpler to just stick with convention that `configFilename = "package.json"` and `configKey = "codegenConfig"`. Changelog: [General][Breaking] - Delete `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. Reviewed By: cipolleschi Differential Revision: D51256486
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 20, 2023
…nfigKey arguments (facebook#41533) Summary: Pull Request resolved: facebook#41533 This diff removes `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. ## Motivation The existing implementation expects every library to have its codegen config in a file with `configFilename` name. `configFilename` is passed as a single CLI argument and applied to every app dependency. I.e. if `configFilename = codegen.config.json` then we expect to find this file in *every* third-party library. That is weird expectation. This customisation option is unsound. Same with `configKey`. It is much simpler to just stick with convention that `configFilename = "package.json"` and `configKey = "codegenConfig"`. Changelog: [General][Breaking] - Delete `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. Differential Revision: https://internalfb.com/D51256486 fbshipit-source-id: a4fc7e0f5569c821f3e948babeea95671d0656e2
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 21, 2023
…nfigKey arguments (facebook#41533) Summary: This diff removes `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. ## Motivation The existing implementation expects every library to have its codegen config in a file with `configFilename` name. `configFilename` is passed as a single CLI argument and applied to every app dependency. I.e. if `configFilename = codegen.config.json` then we expect to find this file in *every* third-party library. That is weird expectation. This customisation option is unsound. Same with `configKey`. It is much simpler to just stick with convention that `configFilename = "package.json"` and `configKey = "codegenConfig"`. Changelog: [General][Breaking] - Delete `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. Reviewed By: cipolleschi Differential Revision: D51256486
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 21, 2023
…nfigKey arguments (facebook#41533) Summary: This diff removes `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. ## Motivation The existing implementation expects every library to have its codegen config in a file with `configFilename` name. `configFilename` is passed as a single CLI argument and applied to every app dependency. I.e. if `configFilename = codegen.config.json` then we expect to find this file in *every* third-party library. That is weird expectation. This customisation option is unsound. Same with `configKey`. It is much simpler to just stick with convention that `configFilename = "package.json"` and `configKey = "codegenConfig"`. Changelog: [General][Breaking] - Delete `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. Reviewed By: cipolleschi Differential Revision: D51256486
dmytrorykun
force-pushed
the
export-D51256486
branch
from
46cb8fe
to
278accb
Compare
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 21, 2023
…nfigKey arguments (facebook#41533) Summary: This diff removes `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. ## Motivation The existing implementation expects every library to have its codegen config in a file with `configFilename` name. `configFilename` is passed as a single CLI argument and applied to every app dependency. I.e. if `configFilename = codegen.config.json` then we expect to find this file in *every* third-party library. That is weird expectation. This customisation option is unsound. Same with `configKey`. It is much simpler to just stick with convention that `configFilename = "package.json"` and `configKey = "codegenConfig"`. Changelog: [General][Breaking] - Delete `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. Reviewed By: cipolleschi Differential Revision: D51256486
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 21, 2023
…nfigKey arguments (facebook#41533) Summary: This diff removes `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. ## Motivation The existing implementation expects every library to have its codegen config in a file with `configFilename` name. `configFilename` is passed as a single CLI argument and applied to every app dependency. I.e. if `configFilename = codegen.config.json` then we expect to find this file in *every* third-party library. That is weird expectation. This customisation option is unsound. Same with `configKey`. It is much simpler to just stick with convention that `configFilename = "package.json"` and `configKey = "codegenConfig"`. Changelog: [General][Breaking] - Delete `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. Reviewed By: cipolleschi Differential Revision: D51256486
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 21, 2023
…nfigKey arguments (facebook#41533) Summary: This diff removes `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. ## Motivation The existing implementation expects every library to have its codegen config in a file with `configFilename` name. `configFilename` is passed as a single CLI argument and applied to every app dependency. I.e. if `configFilename = codegen.config.json` then we expect to find this file in *every* third-party library. That is weird expectation. This customisation option is unsound. Same with `configKey`. It is much simpler to just stick with convention that `configFilename = "package.json"` and `configKey = "codegenConfig"`. Changelog: [General][Breaking] - Delete `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. Reviewed By: cipolleschi Differential Revision: D51256486
|
This pull request was exported from Phabricator. Differential Revision: D51256486 |
…nfigKey arguments (facebook#41533) Summary: This diff removes `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. ## Motivation The existing implementation expects every library to have its codegen config in a file with `configFilename` name. `configFilename` is passed as a single CLI argument and applied to every app dependency. I.e. if `configFilename = codegen.config.json` then we expect to find this file in *every* third-party library. That is weird expectation. This customisation option is unsound. Same with `configKey`. It is much simpler to just stick with convention that `configFilename = "package.json"` and `configKey = "codegenConfig"`. Changelog: [General][Breaking] - Delete `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. Reviewed By: cipolleschi Differential Revision: D51256486
dmytrorykun
force-pushed
the
export-D51256486
branch
from
278accb
to
2743e2e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51256486 |
|
This pull request was successfully merged by @dmytrorykun in 33a44e6. When will my fix make it into a release? | Upcoming Releases |
|
This pull request has been merged in 33a44e6. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
…nfigKey arguments (facebook#41533) Summary: Pull Request resolved: facebook#41533 This diff removes `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. ## Motivation The existing implementation expects every library to have its codegen config in a file with `configFilename` name. `configFilename` is passed as a single CLI argument and applied to every app dependency. I.e. if `configFilename = codegen.config.json` then we expect to find this file in *every* third-party library. That is weird expectation. This customisation option is unsound. Same with `configKey`. It is much simpler to just stick with convention that `configFilename = "package.json"` and `configKey = "codegenConfig"`. Changelog: [General][Breaking] - Delete `configFilename` and `configKey` arguments from iOS codegen CLI. Now we always expect them to be `package.json` and `codegenConfig` respectively. Reviewed By: cipolleschi Differential Revision: D51256486 fbshipit-source-id: fe190b514be7c4e489c7be01294958cf3254602a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff removes
configFilenameandconfigKeyarguments from iOS codegen CLI. Now we always expect them to bepackage.jsonandcodegenConfigrespectively.Motivation
The existing implementation expects every library to have its codegen config in a file with
configFilenamename.configFilenameis passed as a single CLI argument and applied to every app dependency. I.e. ifconfigFilename = codegen.config.jsonthen we expect to find this file in every third-party library. That is weird expectation. This customisation option is unsound. Same withconfigKey. It is much simpler to just stick with convention thatconfigFilename = "package.json"andconfigKey = "codegenConfig".Changelog: [General][Breaking] - Delete
configFilenameandconfigKeyarguments from iOS codegen CLI. Now we always expect them to bepackage.jsonandcodegenConfigrespectively.Differential Revision: D51256486