Handle UTF8 in native exception message #41575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49551640 |
Base commit: a8fc206 |
neildhar
added a commit
to neildhar/react-native
that referenced
this pull request
Nov 21, 2023
Summary: We currently do not validate the incoming native exception message before passing it to the `char*` constructor of `TwineChar16`. Changelog: [Internal] Differential Revision: D49551640
neildhar
force-pushed
the
export-D49551640
branch
from
b541a06
to
328c1d0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49551640 |
neildhar
force-pushed
the
export-D49551640
branch
from
328c1d0
to
99497ca
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49551640 |
Summary: We currently do not validate the incoming native exception message before passing it to the char* constructor of TwineChar16. Treat it as UTF-8 and convert it to UTF-16 before creating the JavaScript exception. Changelog: [Internal] Reviewed By: tmikov Differential Revision: D49551640
neildhar
force-pushed
the
export-D49551640
branch
from
99497ca
to
bbcec87
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49551640 |
facebook-github-bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Nov 29, 2023
Summary: X-link: facebook/react-native#41575 We currently do not validate the incoming native exception message before passing it to the char* constructor of TwineChar16. Treat it as UTF-8 and convert it to UTF-16 before creating the JavaScript exception. Changelog: [Internal] Reviewed By: tmikov Differential Revision: D49551640 fbshipit-source-id: 762f8038b29818d804bda5a7f3b4762621c94336
|
This pull request has been merged in 02b9447. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#41575 We currently do not validate the incoming native exception message before passing it to the char* constructor of TwineChar16. Treat it as UTF-8 and convert it to UTF-16 before creating the JavaScript exception. Changelog: [Internal] Reviewed By: tmikov Differential Revision: D49551640 fbshipit-source-id: 762f8038b29818d804bda5a7f3b4762621c94336
facebook-github-bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Jan 18, 2024
Summary: Original Author: neildhar@meta.com Original Git: 0222f1f Original Reviewed By: tmikov Original Revision: D49551640 X-link: facebook/react-native#41575 We currently do not validate the incoming native exception message before passing it to the char* constructor of TwineChar16. Treat it as UTF-8 and convert it to UTF-16 before creating the JavaScript exception. Changelog: [Internal] Reviewed By: tmikov Differential Revision: D52854476 fbshipit-source-id: d43685e7e5a203f9bfc0bbb2b7ea5f4a3046ab86
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D49551640
We currently do not validate the incoming native exception message
before passing it to the char* constructor of TwineChar16.
Changelog: [Internal]