Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Move ActionSheet UI operation to main thread #41666

Closed
wants to merge 1 commit into from
Closed

[iOS] Move ActionSheet UI operation to main thread #41666

wants to merge 1 commit into from

Conversation

zhongwuzw
Copy link
Contributor

Summary:

Fixes UI operation not on the main thread.
image

image

Changelog:

[IOS] [FIXED] - Move ActionSheet UI operation to main thread

Test Plan:

None.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Nov 28, 2023
cipolleschi
cipolleschi approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix!

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@github-actions GitHub Actions
Copy link

This pull request was successfully merged by @zhongwuzw in aa9e824.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions bot added the Merged This PR has been merged. label Nov 28, 2023
Othinn pushed a commit to Othinn/react-native that referenced this pull request Jan 9, 2024
@zhongwuzw @Othinn
Move ActionSheet UI operation to main thread (facebook#41666)
87a1d6d 
Summary:
Fixes UI operation not on the main thread.
![image](https://github.com/facebook/react-native/assets/5061845/276f7e9c-dcf8-4ba1-af2d-c9fa990d41a1)

![image](https://github.com/facebook/react-native/assets/5061845/cfe85921-3cc9-4f32-b794-a6a8bc00ee1d)

## Changelog:

[IOS] [FIXED] - Move ActionSheet UI operation to main thread

Pull Request resolved: facebook#41666

Test Plan: None.

Reviewed By: philIip

Differential Revision: D51613525

Pulled By: cipolleschi

fbshipit-source-id: e5f543bbcc9bc0f5b6dda5bc2deb20279e851946
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipolleschi cipolleschi cipolleschi approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhongwuzw @facebook-github-bot @cipolleschi