Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of old APIs in FabricUIManagerProvider #42059

Closed
wants to merge 3 commits into from

Conversation

arushikesarwani94
Copy link
Contributor

Summary: Getting rid of old APIs in FabricUIManagerProvider and also clearing it of the inheritance dependency it has on JSIModule post it's references have been cleared.

Differential Revision: D51001239

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Dec 26, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51001239

facebook-github-bot pushed a commit that referenced this pull request Dec 26, 2023
Summary:

Getting rid of old APIs in FabricUIManagerProvider and also clearing it of the inheritance dependency it has on JSIModule post it's references have been cleared.

Differential Revision: D51001239
facebook-github-bot pushed a commit that referenced this pull request Dec 26, 2023
Summary:

Getting rid of old APIs in FabricUIManagerProvider and also clearing it of the inheritance dependency it has on JSIModule post it's references have been cleared.

Differential Revision: D51001239
@analysis-bot
Copy link

analysis-bot commented Dec 26, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,577,971 -4,090
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 19,955,046 -2
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: e75f050
Branch: main

arushikesarwani94 added a commit that referenced this pull request Dec 27, 2023
Summary:

Getting rid of old APIs in FabricUIManagerProvider and also clearing it of the inheritance dependency it has on JSIModule post it's references have been cleared.

Reviewed By: christophpurrer

Differential Revision: D51001239
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51001239

arushikesarwani94 added a commit that referenced this pull request Dec 27, 2023
Summary:

Getting rid of old APIs in FabricUIManagerProvider and also clearing it of the inheritance dependency it has on JSIModule post it's references have been cleared.

Reviewed By: christophpurrer

Differential Revision: D51001239
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51001239

Summary:

 Refactor React to get rid of JSIModule and its dependencies now that the changes are rolled out for all internal apps.

Changelog:
[Internal] Internal

Reviewed By: christophpurrer

Differential Revision: D51058885
Summary:

Getting rid of JSIModule from tests

Changelog:
[Internal] internal

Reviewed By: christophpurrer

Differential Revision: D50925102
Summary:

Getting rid of old APIs in FabricUIManagerProvider and also clearing it of the inheritance dependency it has on JSIModule post it's references have been cleared.

Changelog:
[Internal] Internal

Reviewed By: christophpurrer

Differential Revision: D51001239
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51001239

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Dec 27, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in c2c346c.

@facebook-github-bot facebook-github-bot deleted the export-D51001239 branch December 30, 2023 15:16
Othinn pushed a commit to Othinn/react-native that referenced this pull request Jan 9, 2024
Summary:
Pull Request resolved: facebook#42059

Getting rid of old APIs in FabricUIManagerProvider and also clearing it of the inheritance dependency it has on JSIModule post it's references have been cleared.

Reviewed By: christophpurrer

Differential Revision: D51001239

fbshipit-source-id: c3d4650c292e957e9f939304662932c11af7a24f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants