New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of old APIs in FabricUIManagerProvider #42059
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
p: Facebook
Partner: Facebook
Partner
labels
Dec 26, 2023
This pull request was exported from Phabricator. Differential Revision: D51001239 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 26, 2023
Summary: Getting rid of old APIs in FabricUIManagerProvider and also clearing it of the inheritance dependency it has on JSIModule post it's references have been cleared. Differential Revision: D51001239
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 26, 2023
Summary: Getting rid of old APIs in FabricUIManagerProvider and also clearing it of the inheritance dependency it has on JSIModule post it's references have been cleared. Differential Revision: D51001239
Base commit: e75f050 |
arushikesarwani94
force-pushed
the
export-D51001239
branch
from
December 27, 2023 06:08
491f8cc
to
2c1808b
Compare
arushikesarwani94
added a commit
that referenced
this pull request
Dec 27, 2023
Summary: Getting rid of old APIs in FabricUIManagerProvider and also clearing it of the inheritance dependency it has on JSIModule post it's references have been cleared. Reviewed By: christophpurrer Differential Revision: D51001239
This pull request was exported from Phabricator. Differential Revision: D51001239 |
arushikesarwani94
force-pushed
the
export-D51001239
branch
from
December 27, 2023 06:09
2c1808b
to
c618f9f
Compare
arushikesarwani94
added a commit
that referenced
this pull request
Dec 27, 2023
Summary: Getting rid of old APIs in FabricUIManagerProvider and also clearing it of the inheritance dependency it has on JSIModule post it's references have been cleared. Reviewed By: christophpurrer Differential Revision: D51001239
This pull request was exported from Phabricator. Differential Revision: D51001239 |
Summary: Refactor React to get rid of JSIModule and its dependencies now that the changes are rolled out for all internal apps. Changelog: [Internal] Internal Reviewed By: christophpurrer Differential Revision: D51058885
Summary: Getting rid of JSIModule from tests Changelog: [Internal] internal Reviewed By: christophpurrer Differential Revision: D50925102
Summary: Getting rid of old APIs in FabricUIManagerProvider and also clearing it of the inheritance dependency it has on JSIModule post it's references have been cleared. Changelog: [Internal] Internal Reviewed By: christophpurrer Differential Revision: D51001239
arushikesarwani94
force-pushed
the
export-D51001239
branch
from
December 27, 2023 07:04
c618f9f
to
f5b6bbb
Compare
This pull request was exported from Phabricator. Differential Revision: D51001239 |
This pull request has been merged in c2c346c. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#42059 Getting rid of old APIs in FabricUIManagerProvider and also clearing it of the inheritance dependency it has on JSIModule post it's references have been cleared. Reviewed By: christophpurrer Differential Revision: D51001239 fbshipit-source-id: c3d4650c292e957e9f939304662932c11af7a24f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Merged
This PR has been merged.
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Getting rid of old APIs in FabricUIManagerProvider and also clearing it of the inheritance dependency it has on JSIModule post it's references have been cleared.
Differential Revision: D51001239