Make TurboModuleManager not implement JSIModule #42060
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49977957 |
Base commit: d992abc |
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 28, 2023
Summary: For removal of JSIModule getting rid of the inheritance relationship b/w interfaces TurboModuleManager & JSIModule by directly defining `invalidate()`. `initialize()` here isn't being used hence not defining it. Changelog: [Internal] internal Reviewed By: philIip, mdvacca Differential Revision: D49977957
Summary: For removal of JSIModule getting rid of the inheritance relationship b/w interfaces TurboModuleManager & JSIModule by directly defining `invalidate()`. `initialize()` here isn't being used hence not defining it. Changelog: [Internal] internal Reviewed By: philIip, mdvacca Differential Revision: D49977957
arushikesarwani94
force-pushed
the
export-D49977957
branch
from
5d4ce05
to
c03a3b8
Compare
arushikesarwani94
added a commit
that referenced
this pull request
Dec 28, 2023
Summary: For removal of JSIModule getting rid of the inheritance relationship b/w interfaces TurboModuleManager & JSIModule by directly defining `invalidate()`. `initialize()` here isn't being used hence not defining it. Changelog: [Internal] internal Reviewed By: philIip, mdvacca Differential Revision: D49977957
|
This pull request was exported from Phabricator. Differential Revision: D49977957 |
arushikesarwani94
force-pushed
the
export-D49977957
branch
from
c03a3b8
to
74da993
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49977957 |
|
This pull request has been merged in b507e11. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#42060 For removal of JSIModule getting rid of the inheritance relationship b/w interfaces TurboModuleManager & JSIModule by directly defining `invalidate()`. `initialize()` here isn't being used hence not defining it. Changelog: [Internal] internal Reviewed By: philIip, mdvacca Differential Revision: D49977957 fbshipit-source-id: 8de644b1f344d8ce8d4a78655556829f860a2b10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
For removal of JSIModule getting rid of the inheritance relationship b/w interfaces TurboModuleManager & JSIModule by directly defining
invalidate().initialize()here isn't being used hence not defining it.Changelog:
[Internal] internal
Reviewed By: philIip, mdvacca
Differential Revision: D49977957