Making UIManager not implement JSIModule #42061
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49306312 |
|
This pull request was exported from Phabricator. Differential Revision: D49306312 |
arushikesarwani94
force-pushed
the
export-D49306312
branch
from
0f164a9
to
6611883
Compare
arushikesarwani94
added a commit
that referenced
this pull request
Dec 29, 2023
Summary: Pull Request resolved: #42061 For removal of JSIModule getting rid of the inheritance relationship b/w interfaces UIManager & JSIModule by directly defining `initialize()` and `invalidate()` Changelog: [Internal] internal Reviewed By: philIip, mdvacca Differential Revision: D49306312 fbshipit-source-id: c587d7e50a5275b3a2bc5f0351252141d11637b9
|
This pull request was exported from Phabricator. Differential Revision: D49306312 |
arushikesarwani94
force-pushed
the
export-D49306312
branch
from
6611883
to
6ee1fff
Compare
arushikesarwani94
added a commit
that referenced
this pull request
Jan 2, 2024
Summary: Pull Request resolved: #42061 For removal of JSIModule getting rid of the inheritance relationship b/w interfaces UIManager & JSIModule by directly defining `initialize()` and `invalidate()` Changelog: [Internal] internal Reviewed By: philIip, mdvacca Differential Revision: D49306312 fbshipit-source-id: 03a0be5a15defdf81cfa5993d506d45e21edee1a
Summary: Since we switched all apps from `getJSIModule()` to `getFabricUIManager()` from `ReactContext` and it's subclasses it's safe to delete this method. NOTE: The fallback for FabricUIManager is still catalystInstance.getJSIModule() that's still there for backwards comptability just deleting the indirection through ReactContext Differential Revision: D51748655 fbshipit-source-id: 3ba406b11b5bafcfcce1aa3cf6f7d951505f96c6
Summary: Pull Request resolved: #42061 For removal of JSIModule getting rid of the inheritance relationship b/w interfaces UIManager & JSIModule by directly defining `initialize()` and `invalidate()` Changelog: [Internal] internal Reviewed By: philIip, mdvacca Differential Revision: D49306312 fbshipit-source-id: 7e7cad2b3850c0a8a3f93644769f2f76f3ece2ff
|
This pull request was exported from Phabricator. Differential Revision: D49306312 |
arushikesarwani94
force-pushed
the
export-D49306312
branch
from
6ee1fff
to
35eb1d4
Compare
|
This pull request has been merged in af8c56a. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#42061 For removal of JSIModule getting rid of the inheritance relationship b/w interfaces UIManager & JSIModule by directly defining `initialize()` and `invalidate()` Changelog: [Internal] internal Reviewed By: philIip, mdvacca Differential Revision: D49306312 fbshipit-source-id: 041870418e13bb4b2381e609b94331c87be5f6fa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
For removal of JSIModule getting rid of the inheritance relationship b/w interfaces UIManager & JSIModule by directly defining
initialize()andinvalidate()Changelog:
[Internal] internal
Reviewed By: philIip, mdvacca
Differential Revision: D49306312