Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the last Unit Tests to Kotlin #42078

Closed
wants to merge 1 commit into from

Conversation

cortinico
Copy link
Contributor

Summary:
Resubmit of D51891716 and D52033328

I'm doing a pass and converting the last Java Unit Tests we had to Kotlin
I've also re-enabled multiple tests that were disabled in the past.

Changelog:
[Internal] [Changed] - Convert the last Unit Tests to Kotlin

Differential Revision: D52430728

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 27, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52430728

cortinico added a commit to cortinico/react-native that referenced this pull request Dec 27, 2023
Summary:

Resubmit of D51891716 and D52033328

I'm doing a pass and converting the last Java Unit Tests we had to Kotlin
I've also re-enabled multiple tests that were disabled in the past.

Changelog:
[Internal] [Changed] - Convert the last Unit Tests to Kotlin

Differential Revision: D52430728
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52430728

@analysis-bot
Copy link

analysis-bot commented Dec 27, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,577,956 +12
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 19,955,048 +3
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: ffe219c
Branch: main

cortinico added a commit to cortinico/react-native that referenced this pull request Dec 27, 2023
Summary:

Resubmit of D51891716 and D52033328

I'm doing a pass and converting the last Java Unit Tests we had to Kotlin
I've also re-enabled multiple tests that were disabled in the past.

Changelog:
[Internal] [Changed] - Convert the last Unit Tests to Kotlin

Differential Revision: D52430728
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52430728

cortinico added a commit to cortinico/react-native that referenced this pull request Dec 27, 2023
Summary:

Resubmit of D51891716 and D52033328

I'm doing a pass and converting the last Java Unit Tests we had to Kotlin
I've also re-enabled multiple tests that were disabled in the past.

Changelog:
[Internal] [Changed] - Convert the last Unit Tests to Kotlin

Differential Revision: D52430728
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52430728

Summary:

Resubmit of D51891716 and D52033328

I'm doing a pass and converting the last Java Unit Tests we had to Kotlin
I've also re-enabled multiple tests that were disabled in the past.

Changelog:
[Internal] [Changed] - Convert the last Unit Tests to Kotlin

Reviewed By: rshest

Differential Revision: D52430728
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52430728

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Dec 27, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in c75abef.

Othinn pushed a commit to Othinn/react-native that referenced this pull request Jan 9, 2024
Summary:
Pull Request resolved: facebook#42078

Resubmit of D51891716 and D52033328

I'm doing a pass and converting the last Java Unit Tests we had to Kotlin
I've also re-enabled multiple tests that were disabled in the past.

Changelog:
[Internal] [Changed] - Convert the last Unit Tests to Kotlin

Reviewed By: rshest

Differential Revision: D52430728

fbshipit-source-id: e6b4a6ed88d852024d959cf5148e992e97a84434
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants