Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added #content hash to debugging link so that it scrolls to start of content on mobile #424

Merged
merged 1 commit into from
Mar 29, 2015
Merged

Added #content hash to debugging link so that it scrolls to start of content on mobile #424

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion website/src/react-native/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ var App = React.createClass({
All operations between the JavaScript application code and the native platform are performed asynchronously, and the native modules can also make use of additional threads as well. This means we can decode images off of the main thread, save to disk in the background, measure text and compute layouts without blocking the UI, and more. As a result, React Native apps are naturally fluid and responsive. The communication is also fully serializable, which allows us to leverage Chrome Developer Tools to debug the JavaScript while running the complete app, either in the simulator or on a physical device.
</p>
<p>
See <a href="docs/debugging.html">Debugging</a>.
See <a href="docs/debugging.html#content">Debugging</a>.
</p>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this change, when clicking on the link on mobile you get sent to the Debugging page but scrolled to the top of the page. Because the menu system goes first and is long, it can seem like the page is broken or the content is missing.

Ultimately the site just needs better mobile support and links shouldn't have to require #content everywhere. But alas, that's where we are now.

<img src="/react-native/img/chrome_breakpoint.png" width="800" height="443" />

Expand Down