Do not serialize text attributes that are not used later

[cubuspl42]

Summary:

Do not serialize text attributes that are not used later

Changelog:

[INTERNAL] [REMOVED] - Do not serialize text attributes that are not used later

Test Plan:

[cubuspl42]

We're deserializing text attributes of a fragment. Some attributes are not handled on the fragment level but apply to the whole Text element. I believe there's not much more to investigate here.

[cubuspl42]

Relevant:

react-native/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/TextAttributeProps.java

Lines 31 to 33 in 27f3810

	// TODO: T63643819 refactor naming of TextAttributeProps to make explicit that this represents
	// TextAttributes and not TextProps. As part of this refactor extract methods that don't belong to
	// TextAttributeProps (e.g. TextAlign)

[cubuspl42]

The fact that we currently don't do what this comment describes is blocking me.

I'd like to...

• Split TextAttributes (C++) to TextAttributes (<Text>-level properties) and FragmentAttributes (fragment-level properties)
• Refactor TextAttributeProps (Java) to FragmentAttributes

Currently, one is a subset of another; not modeling them separately is at most a code smell.

I'd like them to be two slightly different sets (sharing a great common subset), so not modeling them separately is a problem.

[mdvacca]

yes, this doesn't seem correct, thanks for cleaning up

[cubuspl42]

@mdvacca I think I will need your eyes on this one.

Please see this thread.

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	17,066,827	-5
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	20,450,423	-9
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: cfc0ba0
Branch: main

[cubuspl42]

@mdvacca What do you think? Is this a good way forward?

[facebook-github-bot]

@mdvacca has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[mdvacca]

yes, this doesn't seem correct, thanks for cleaning up

[cubuspl42]

@mdvacca Let me know if I can help with making the internal build succeed