Hook the default-app-setup OnLoad.cpp file with the cxxModuleProvider from RNCLI #43049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D53812109 |
Base commit: 3a1e769 |
2 tasks
...e-gradle-plugin/src/test/kotlin/com/facebook/react/tasks/GenerateCodegenArtifactsTaskTest.kt
Outdated
Show resolved
Hide resolved
cortinico
force-pushed
the
export-D53812109
branch
from
8bc8cc3
to
7f8d9f0
Compare
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Feb 19, 2024
… from RNCLI (facebook#43049) Summary: This connects the OnLoad.cpp file used by OSS apps with the `rncli_cxxModuleProvider`. This method is created by the CLI and takes care of querying all the TM CXX Modules discovered and returning them. This PR is currently waiting on react-native-community/cli#2296 Changelog: [Internal] [Changed] - Hook the default-app-setup OnLoad.cpp file with the cxxModuleProvider from RNCLI Reviewed By: cipolleschi Differential Revision: D53812109
|
This pull request was exported from Phabricator. Differential Revision: D53812109 |
|
This pull request was exported from Phabricator. Differential Revision: D53812109 |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Feb 19, 2024
… from RNCLI (facebook#43049) Summary: Pull Request resolved: facebook#43049 This connects the OnLoad.cpp file used by OSS apps with the `rncli_cxxModuleProvider`. This method is created by the CLI and takes care of querying all the TM CXX Modules discovered and returning them. This PR is currently waiting on react-native-community/cli#2296 Changelog: [Internal] [Changed] - Hook the default-app-setup OnLoad.cpp file with the cxxModuleProvider from RNCLI Reviewed By: cipolleschi Differential Revision: D53812109
cortinico
force-pushed
the
export-D53812109
branch
from
7f8d9f0
to
1340378
Compare
Summary: Bump CLI version to 13.6.0 ## Changelog: [GENERAL] [CHANGED] - Bump CLI to 13.6.0 Pull Request resolved: facebook#43093 Test Plan: CI Differential Revision: D53920559 Pulled By: cortinico
… from RNCLI (facebook#43049) Summary: Pull Request resolved: facebook#43049 This connects the OnLoad.cpp file used by OSS apps with the `rncli_cxxModuleProvider`. This method is created by the CLI and takes care of querying all the TM CXX Modules discovered and returning them. This PR is currently waiting on react-native-community/cli#2296 Changelog: [Internal] [Changed] - Hook the default-app-setup OnLoad.cpp file with the cxxModuleProvider from RNCLI Reviewed By: cipolleschi Differential Revision: D53812109
|
This pull request was exported from Phabricator. Differential Revision: D53812109 |
cortinico
force-pushed
the
export-D53812109
branch
from
1340378
to
bc9f00e
Compare
|
This pull request has been merged in 4ecf57e. |
huntie
pushed a commit
that referenced
this pull request
Feb 22, 2024
… from RNCLI (#43049) Summary: Pull Request resolved: #43049 This connects the OnLoad.cpp file used by OSS apps with the `rncli_cxxModuleProvider`. This method is created by the CLI and takes care of querying all the TM CXX Modules discovered and returning them. This PR is currently waiting on react-native-community/cli#2296 Changelog: [Internal] [Changed] - Hook the default-app-setup OnLoad.cpp file with the cxxModuleProvider from RNCLI Reviewed By: cipolleschi Differential Revision: D53812109 fbshipit-source-id: 47bc0ea699516993070cfa0127de97853acf8890
This was referenced Apr 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This connects the OnLoad.cpp file used by OSS apps with the
rncli_cxxModuleProvider.This method is created by the CLI and takes care of querying all the TM CXX Modules discovered and returning them.
Changelog:
[Internal] [Changed] - Hook the default-app-setup OnLoad.cpp file with the cxxModuleProvider from RNCLI
Differential Revision: D53812109