Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix findLibrariesFromReactNativeConfig #43210

Closed
wants to merge 1 commit into from
Closed

Fix findLibrariesFromReactNativeConfig #43210

wants to merge 1 commit into from
+1 −5

Commits on Feb 27, 2024

  1. Fix findLibrariesFromReactNativeConfig 

    Summary:
This diff removes extra argument from the `extractLibrariesFromJSON` call inside `findLibrariesFromReactNativeConfig`.
This should fix the iOS failurte discribed in facebook#43204
Changelog: [iOS][Fixed] - Codegen correctly handles react-native.config.js.

Reviewed By: cipolleschi

Differential Revision: D54248400
    @dmytrorykun @facebook-github-bot
    dmytrorykun authored and facebook-github-bot committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    630bfa0 View commit details
    Browse the repository at this point in the history