Enable background drawables outside of ReactViewGroup #43723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D55565035
Summary: ReactViewGroup hosts border drawing and clipping drawable as a background drawable, sometimes placing it in a layer with another existing drawable. This roughly tries to replicate that, but with view managers assuming some level of ownership of any background drawables set on the underlying view. We replicate same rough behavior for ReactViewGroup before, but now ViewManagers could add these background drawables to arbitrary view-managers. Enabling e.g. box-shadow in more places. I am not 100% on some of the details here around LayerDrawable invalidation. Changelog: [Internal] Differential Revision: D55565114
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55565114 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
ReactViewGroup hosts border drawing and clipping drawable as a background drawable, sometimes placing it in a layer with another existing drawable.
This roughly tries to replicate that, but with view managers assuming some level of ownership of any background drawables set on the underlying view.
We replicate same rough behavior for ReactViewGroup before, but now ViewManagers could add these background drawables to arbitrary view-managers. Enabling e.g. box-shadow in more places.
I am not 100% on some of the details here around LayerDrawable invalidation.
Changelog: [Internal]
Differential Revision: D55565114