Properly recycle RCTPullToRefreshViewcomponentView #44047
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56018924 |
Summary: This change properly recycles the RCTPullToRefreshViewComponentView so that it fixes some misbehaviors of the UIRefreshControl in OSS. This should fix facebook#37308 and facebook#36173 ## Changelog: [iOS][Fixed] - Properly recycle the RCTPullToRefreshViewComponentView Differential Revision: D56018924
cipolleschi
force-pushed
the
export-D56018924
branch
from
0fc6090
to
4b625f4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56018924 |
|
@cipolleschi Next to your testing on my reproducer, I also reverted the project from which my issue originated to the state it was in when I found this bug. After applying the changes provided in this pull request, refreshing indeed works as intended again. Great work, and thanks for fixing this :) |
|
This pull request has been merged in 18f0a90. |
|
This pull request was successfully merged by @cipolleschi in 18f0a90. When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change properly recycles the RCTPullToRefreshViewComponentView so that it fixes some misbehaviors of the UIRefreshControl in OSS.
This should fix #37308 and #36173
Changelog:
[iOS][Fixed] - Properly recycle the RCTPullToRefreshViewComponentView
Differential Revision: D56018924