New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS[accessibility]: Added accessibility split focus prop for iOS #44117
base: main
Are you sure you want to change the base?
Conversation
cc @hoxyq @cipolleschi since this is an |
Base commit: 237ddb4 |
need some help with the snapshot 😅 |
@blakef has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@blakef could you help me know what failed since this looks like only accessible to only meta members! |
@hoxyq need some help on the fb internal test fail could you help! |
friendly ping @blakef |
ef1c53b
to
c05dea3
Compare
Hi @Biki-das, thanks for the PR. We'll get back to you on this when we're in a position to give useful feedback (so no need to ping). I'm gathering more feedback (always hard to get for accessibility work) on whether this is the best approach. One bit of feedback we've already had is that the bar is very high to add additional API. You can make my life a little easier for me here. Can you motivate why we'd need the |
thanks @blakef for the detailed feedback and sorry for the pings, i understand adding a new API and its maintenance is additional work, the convincing point for this Prop exactly in my opinion is, this Prop would bring some consistency with android where accessing nested view is easy you just need to pass the accessible prop and you can access nested child views!
i hope the above just clears the usage of this Prop, coming to the second question why not make it the default behaviour and not an additional prop, In my opinion, the case for looking inside child Views should not always be the default case, Developers might just want to skim through all the parent views and if only they feel they might want to investigate the child views, and just inspect the nested ones. i would consider this as a specific case rather than a general and that is why, engineers who worked on react native did not made the same way. ofcourse would love to know other core contributors/maintainers thoughts on the same. |
Summary:
Currently in iOS we have no way to access nested elements in a View through accessibility methods such has voice over
like if we have hierarchy like below
We cannot focus on the individual child elements and get accessibility details which works on android, to allow for the same, i have tried to supply an additional Prop limited to iOS called
accessibilitySplitFocus
which when set totrue
will allow for the child elements to be accessible further.nested.accessibility.prop.mp4
Using the mac accessibility inspector i have tested whether it works or not
Changelog:
[iOS] [Added] - iOS[accessibility]: Added accessibility split focus prop for iOS
Test Plan:
Added a new Example which demonstrates the same, this would require either testing in local device using voice over turned or using the mac inbuilt accessibility inspector.