Moved @react-native-community script internally into react-native/scripts #44136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56242486 |
Base commit: 2f1cd04 |
…ipts (facebook#44136) Summary: Our iOS autolinking code needs to do two things: 1. discover all the modules 2. add the pods in those modules to our main Podfile This used to happen all in one Ruby method, I've broken it up into two so framework authors were constrainted to have to use `npx react-native-community/cli config` to gather all the modules. They will, however, have to pass the module details in much the same fashion. For our `internal-template`, I'll do some handwaving to not use the community cli as an example. That's not in here atm, but will be on a later commit. Changelog: [General][Added] - Moved community cli autolinking into react-native/scripts Differential Revision: D56242486
blakef
force-pushed
the
export-D56242486
branch
from
b316cb6
to
f2c0f65
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56242486 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Our iOS autolinking code needs to do two things:
This used to happen all in one Ruby method, I've broken it up into two so framework authors were constrainted to have to use
npx react-native-community/cli configto gather all the modules.They will, however, have to pass the module details in much the same fashion.
For our
internal-template, I'll do some handwaving to not use the community cli as an example. That's not in here atm, but will be on a later commit.Differential Revision: D56242486