Defines module for React-jsinspector #44252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
10 tasks
|
@cipolleschi could you help to take a look for this change when you get a chance? |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi merged this pull request in 4e61865. |
|
This pull request was successfully merged by @Kudo in 4e61865. When will my fix make it into a release? | How to file a pick request? |
cipolleschi
pushed a commit
that referenced
this pull request
May 1, 2024
Summary: Defines module for `React-jsinspector` that for swift modules to integrate with. to fix expo/expo#28209, any podspec depends on HermesExecutorFactory should use ` add_dependency(s, "React-jsinspector", :framework_name => 'jsinspector_modern')` to add dependency. otherwise it will encounter the header not found issue because use_frameworks will change "jsinspector-modern" to "jsinspector_modern". to depend on React-jsinspector from expo-modules-core, we need it to define as a module. otherwise, it will have the error ``` The Swift pod `ExpoModulesCore` depends upon `React-jsinspector`, which does not define modules. To opt into those targets generating module maps (which is necessary to import them from Swift when building as static libraries), you may set `use_modular_headers!` globally in your Podfile, or specify `:modular_headers => true` for particular dependencies. ``` ## Changelog: [IOS] [CHANGED] - Add `DEFINES_MODULE` for React-jsinspector.podspec Pull Request resolved: #44252 Test Plan: ci passed Reviewed By: cortinico Differential Revision: D56575102 Pulled By: cipolleschi fbshipit-source-id: 9b7b4568a3e499f0a741a79a846263118ff2d112
Kudo
added a commit
to expo/expo
that referenced
this pull request
May 3, 2024
# Why fix header not found issue when using frameworks on new architecture fixes #28209 # How the header search path is from `EXJavaScriptRuntime.mm -> HermesExecutorFactory.h -> <jsinspector-modern/InspectorInterfaces.h>`. the correct import should be underlined "jsinspector_modern" in the import. the code is inside react-native core that we cannot touch. this pr tries to use the `add_dependency()` from react-native core that we specify extra ":framework_name". also cleanup some unused search paths that are added through `install_modules_dependencies()`. we also have to wait 0.74.1 for facebook/react-native#44252
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Defines module for
React-jsinspectorthat for swift modules to integrate with.to fix expo/expo#28209, any podspec depends on HermesExecutorFactory should use
add_dependency(s, "React-jsinspector", :framework_name => 'jsinspector_modern')to add dependency. otherwise it will encounter the header not found issue because use_frameworks will change "jsinspector-modern" to "jsinspector_modern".to depend on React-jsinspector from expo-modules-core, we need it to define as a module.
otherwise, it will have the error
Changelog:
[IOS] [CHANGED] - Add
DEFINES_MODULEfor React-jsinspector.podspecTest Plan:
ci passed