-
Notifications
You must be signed in to change notification settings - Fork 24k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix react
peer dependency to support react
v18.3
#44325
base: main
Are you sure you want to change the base?
Conversation
Hi @aryaemami59! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Base commit: b5fd041 |
…fix-react-peer-dependency
…ami59/react-native; branch 'main' of https://github.com/facebook/react-native into fix-react-peer-dependency
…fix-react-peer-dependency
…fix-react-peer-dependency
What's the ETA on a release with this fix? 18.3 is functionally the same as 18.2, but with deprecation warnings. This should be an easy upgrade. |
…fix-react-peer-dependency
…fix-react-peer-dependency
Summary:
This PR updates the peer dependency for React to support version 18.3. The motivation for this change stems from an issue where installing React 18.3 alongside React Native results in npm errors due to strict peer dependency enforcement. This was causing npm to throw errors because the existing configuration did not support React 18.3.
Changelog:
[GENERAL] [CHANGED] - Update
react
peer dependency to include support forreact
v18.3 to resolve npm strict peer dependency errors.Test Plan:
Since the release of React 18.3 does not introduce breaking changes but adds warnings for deprecated APIs to prepare for React 19, no new specific tests were added for this update. Please let me know if I need to change anything.