Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix react peer dependency to support react v18.3 #44325

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

aryaemami59
Copy link

@aryaemami59 aryaemami59 commented Apr 30, 2024

Summary:

This PR updates the peer dependency for React to support version 18.3. The motivation for this change stems from an issue where installing React 18.3 alongside React Native results in npm errors due to strict peer dependency enforcement. This was causing npm to throw errors because the existing configuration did not support React 18.3.

Changelog:

[GENERAL] [CHANGED] - Update react peer dependency to include support for react v18.3 to resolve npm strict peer dependency errors.

Test Plan:

Since the release of React 18.3 does not introduce breaking changes but adds warnings for deprecated APIs to prepare for React 19, no new specific tests were added for this update. Please let me know if I need to change anything.

@facebook-github-bot
Copy link
Contributor

Hi @aryaemami59!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 30, 2024
@analysis-bot
Copy link

analysis-bot commented Apr 30, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,675,020 +13
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 23,044,550 +10
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: b5fd041
Branch: main

@aryaemami59 aryaemami59 marked this pull request as ready for review April 30, 2024 04:54
@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Apr 30, 2024
@paulschreiber
Copy link
Contributor

What's the ETA on a release with this fix? 18.3 is functionally the same as 18.2, but with deprecation warnings. This should be an easy upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants