Fix findNodeAtPoint returns incorrect view #44327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Base commit: 61f584c |
realsoelynn
force-pushed
the
export-D56334314
branch
from
0facbc2
to
9c36335
Compare
Summary: - This fix majority work is based off of hoxyq https://www.internalfb.com/diff/D56185630 Changelog: [Internal] `Expectation`: In React DevTools, user should be able to select an element on screen and it will show you what React component rendered it. This doesn't work in RN app that is using JS navigation `Root Cause`: In Fabric, when we try to find `ShadowNode` in the `ShadowTree`, `pointerEvents` props are not considered during the lookup of node using coordinate. Hence, in React DevTools when we inspect element, it was hightlighting the overlay `View` with `pointerEvents` props `box-none` was getting highlighted instead of its children view in the hierarchy. Reviewed By: javache Differential Revision: D56334314
realsoelynn
force-pushed
the
export-D56334314
branch
from
9c36335
to
da45bce
Compare
|
It was synced in this commit a9a7382 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Expectation: In React DevTools, user should be able to select an element on screen and it will show you what React component rendered it. This doesn't work in RN app that is using JS navigationRoot Cause:In Fabric, when we try to find
ShadowNodein theShadowTree,pointerEventsprops are not considered during the lookup of node using coordinate. Hence, in React DevTools when we inspect element, it was hightlighting the overlayViewwithpointerEventspropsbox-nonewas getting highlighted instead of its children view in the hierarchy.Differential Revision: D56334314